Refuse a two-part version here too, not six minutes in - #567
Merged
Conversation
app/build.gradle stopped padding a missing third part, so 'v4.7' is a build error now. This script is the thing that is supposed to catch a bad version before the gradle setup, and it still accepted one to three parts - so the one shape that newly cannot build walked straight past the check and died in the build instead. The v4.7 tag that reached origin on the 3rd and started a release run is what this would have stopped in seconds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RsdTta67FZ4KeNfPPw5BVL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/build.gradlestopped padding a missing third part in #565, sov4.7is a build error now..github/scripts/resolve-version.pyexists to catch a bad version before the six minutes of gradle setup — and it still accepted one to three parts, so the one shape that newly cannot build was the one shape it waved through.{0,2}becomes{2}, and the error message says which rule was broken.Not hypothetical: a
v4.7tag reached origin on the 3rd, the day after 4.13.0 went out, and started a full release run of a week-old commit that had to be cancelled by hand. This would have ended it at the resolve step.The pre-
v4.8.0tags are two-part and can therefore no longer be re-run through the release workflow. That is already true of the build itself, which is where it is enforced; this only moves the failure earlier.🤖 Generated with Claude Code