Skip to content

fix: Fixes CI test for failing migration - #371

Merged
feanil merged 1 commit into
openedx:masterfrom
open-craft:farhaan/adds-django-to-test
Aug 26, 2026
Merged

fix: Fixes CI test for failing migration#371
feanil merged 1 commit into
openedx:masterfrom
open-craft:farhaan/adds-django-to-test

Conversation

@farhaanbukhsh

@farhaanbukhsh farhaanbukhsh commented Aug 25, 2026

Copy link
Copy Markdown
Member

Description

Fixes the migration check in the CI

Supporting information

From past few days the PRs are facing issue of failing CI checks which are happening because of DRF and Django version mismatch.

Testing instructions

Check CI

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 25, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @openedx/openedx-unmaintained.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Aug 25, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 25, 2026
@farhaanbukhsh
farhaanbukhsh force-pushed the farhaan/adds-django-to-test branch from e21a728 to 41b82e1 Compare August 25, 2026 12:03
@farhaanbukhsh
farhaanbukhsh requested review from feanil and a lite review from Copilot August 25, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the PostgreSQL migrations-check GitHub Actions workflow to apply Open edX common Python constraints when installing test dependencies, preventing unintended Django/DRF version combinations during the migration run.

Changes:

  • Install requirements/test.txt under requirements/common_constraints.txt constraints in the migrations checker workflow to avoid version drift during dependency resolution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/migrations-checker-postgresql.yml Outdated
@farhaanbukhsh

Copy link
Copy Markdown
Member Author

@feanil this is fixing the migration test, the failing test is because of container failure if we re-run it, this might pass.

@farhaanbukhsh
farhaanbukhsh force-pushed the farhaan/adds-django-to-test branch from 41b82e1 to cbbbeae Compare August 25, 2026 12:11

@feanil feanil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a comment to explain this because it looked odd at first glance.

Comment thread .github/workflows/migrations-checker-postgresql.yml
@feanil

feanil commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@farhaanbukhsh can you make this or similar update? I can't edit this PR.

Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
@farhaanbukhsh
farhaanbukhsh force-pushed the farhaan/adds-django-to-test branch from cbbbeae to 712d85c Compare August 25, 2026 17:23
@farhaanbukhsh

Copy link
Copy Markdown
Member Author

@feanil done :)

@feanil
feanil merged commit 1003a4c into openedx:master Aug 26, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants