fix: Fixes CI test for failing migration - #371
Conversation
|
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
e21a728 to
41b82e1
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the PostgreSQL migrations-check GitHub Actions workflow to apply Open edX common Python constraints when installing test dependencies, preventing unintended Django/DRF version combinations during the migration run.
Changes:
- Install
requirements/test.txtunderrequirements/common_constraints.txtconstraints in the migrations checker workflow to avoid version drift during dependency resolution.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@feanil this is fixing the migration test, the failing test is because of container failure if we re-run it, this might pass. |
41b82e1 to
cbbbeae
Compare
feanil
left a comment
There was a problem hiding this comment.
Looks good, added a comment to explain this because it looked odd at first glance.
|
@farhaanbukhsh can you make this or similar update? I can't edit this PR. |
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
cbbbeae to
712d85c
Compare
|
@feanil done :) |
Description
Fixes the migration check in the CI
Supporting information
From past few days the PRs are facing issue of failing CI checks which are happening because of DRF and Django version mismatch.
Testing instructions
Check CI
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.