Bump react-intl to v10 - #288
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
|
||
| const op = helpButtonSlotOperation({ appId: TEST_APP_ID, role: TEST_ROLE }); | ||
| // The following is for TypeScript, since `WidgetRendererProps` sometimes has 'element' and sometimes 'component'. | ||
| if (!('element' in op)) throw new Error(`Expected ${op} to have an 'element'.`); |
There was a problem hiding this comment.
This fix is totally unrelated, but npm run dev wasn't working until I fixed this. I think our CI is not properly checking the shell for TypeScript errors!
This bumps
react-intlto v10. The only significant API change that affects our MFEs as far as I know is thatinjectIntlandintlShapeare removed, but we shouldn't be using those anyways.I tested this in
frontend-app-instructor-dashboardand it seems to be working fine, although setting it up inpackages/was still a pain due to issues like this.Fixes #280 - I updated the runtime's
i18nmodule while I'm at it, to match the latest fromfrontend-platform(basically converts it to TypeScript and removesinjectIntl; no other major changes).Motivation:
react-intlpin theirtypescriptdependency; this version avoids that and lets us decide which TypeScript version to use independently ofreact-intl.package-lock.jsonby about 234 lines 😎