Skip to content

Bump react-intl to v10 - #288

Open
bradenmacdonald wants to merge 2 commits into
mainfrom
braden/react-intl-bump
Open

Bump react-intl to v10#288
bradenmacdonald wants to merge 2 commits into
mainfrom
braden/react-intl-bump

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This bumps react-intl to v10. The only significant API change that affects our MFEs as far as I know is that injectIntl and intlShape are removed, but we shouldn't be using those anyways.

I tested this in frontend-app-instructor-dashboard and it seems to be working fine, although setting it up in packages/ was still a pain due to issues like this.

Fixes #280 - I updated the runtime's i18n module while I'm at it, to match the latest from frontend-platform (basically converts it to TypeScript and removes injectIntl; no other major changes).

Motivation:

  1. Earlier version of react-intl pin their typescript dependency; this version avoids that and lets us decide which TypeScript version to use independently of react-intl.
  2. Simplifies our dependencies - as you can see, this reduces package-lock.json by about 234 lines 😎

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 13, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.


const op = helpButtonSlotOperation({ appId: TEST_APP_ID, role: TEST_ROLE });
// The following is for TypeScript, since `WidgetRendererProps` sometimes has 'element' and sometimes 'component'.
if (!('element' in op)) throw new Error(`Expected ${op} to have an 'element'.`);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is totally unrelated, but npm run dev wasn't working until I fixed this. I think our CI is not properly checking the shell for TypeScript errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

Re-export IntlShape from the runtime barrel

2 participants