Skip to content

refactor: remove dead settings.FEATURES grabs in xmodule #39016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
feanil wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −10
Draft

refactor: remove dead settings.FEATURES grabs in xmodule #39016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions xmodule/capa_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import nh3
from django.conf import settings
from django.core.exceptions import ImproperlyConfigured
from django.template.loader import render_to_string
from django.utils.encoding import smart_str
from django.utils.functional import cached_property
Expand Down Expand Up @@ -73,12 +72,6 @@
MAX_RANDOMIZATION_BINS = 1000


try:
FEATURES = getattr(settings, "FEATURES", {})
except ImproperlyConfigured:
FEATURES = {}


class SHOWANSWER: # pylint: disable=too-few-public-methods
"""
Constants for when to show answer
Expand Down
3 changes: 0 additions & 3 deletions xmodule/partitions/partitions_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import logging
from typing import Dict # noqa: UP035

from django.conf import settings
from django.contrib.auth import get_user_model
from opaque_keys.edx.keys import CourseKey

Expand All @@ -21,8 +20,6 @@

log = logging.getLogger(__name__)

FEATURES = getattr(settings, 'FEATURES', {})


@request_cached()
def get_all_partitions_for_course(course, active_only=False):
Expand Down
Loading