Repository navigation
feat: add management command context manager filter - #39194
rahulkanneri-2u wants to merge 9 commits into
Conversation
|
Once openedx/openedx-filters#400 is merged and released, I will update this PR to use the public filter import, update the dependency as needed, mark the PR ready for review, and request final review. |
|
@pwnage101 @feanil Could you review this PR so I can take it forward? I have made the required changes after merging openedx/openedx-filters#400 |
robrap
left a comment
There was a problem hiding this comment.
Used Claude to find some open issues from the last PR. In addition to the comments added:
- There is no test coverage. How challenging would that be?
- Claude wrote "Before django.setup(). Pipeline steps get imported before the app registry is ready. The merged filter docstring doesn't mention this. It belongs in a follow-up on openedx-filters, not in this PR." Does it make sense to update docs here and/or in openedx-filters about the timing?
- You could update the PR description to note that #400 is merged and released as v3.16.0.
@robrap thanks for the review, addressed in 3a21503:
|
c67fc22 to
3a21503
Compare
robrap
left a comment
There was a problem hiding this comment.
Can we add a min constraint to
openedx-platform/pyproject.toml
Line 102 in 2b84871
@robrap Added >=3.16.0 to the openedx-filters entry in pyproject.toml with a comment on why, and updated uv.lock to match. |
|
@feanil: Let me know if you want to review this related PR, or if I should go ahead and merge. Thank you. |
Description
Add a pluggable filter hook in
manage.pyso Django management command execution can be wrapped by configured Open edX filter pipelines. This provides a public integration point without embedding organization-specific monitoring logic inedx-platform.This impacts Developers and Operators who configure or run Django management commands. There are no UI changes.
Supporting information
Private reference ticket: https://2u-internal.atlassian.net/browse/LP-1263
Testing instructions
python manage.py lms checkand verify the command completes normally when no filter pipeline is configured.org.openedx.management.command.contextmanager.requested.v1that returns a context manager.python manage.py lms check.Deadline
None.
Other information