Repository navigation
build: pin Node to 24.22.1 (Node.js security release) - #39313
Open
brobro10000 wants to merge 1 commit into
Open
brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
Node 24.22.1 is the patched 24.x release from Node.js's October 2026 security release. Naming the exact version keeps CI from using an older, unpatched 24.x that's already cached on the runner image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brobro10000
marked this pull request as ready for review
October 26, 2026 15:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
.nvmrcto 24.22.1 (was24). This is the patched 24.x release from Node.js's October 2026 security release, which fixes a critical vulnerability. The patched releases are 22.23.4, 24.22.1 and 26.12.1. Node 20 and older get no fix.Who reads
.nvmrcNothing inside this repo reads it at build time. The only in-repo reference is
README.rst, which points developers to the file. Operators and developer tooling that follow it (nvm, nodeenv) get the patched version. nodeenv passes an exact version through as-is, so the full version pin doesn't break it.Not in this PR
js-tests.yml,quality-checks.ymlandstatic-assets-check.ymlsetnode-version: [20]directly and don't read.nvmrc. This PR therefore doesn't change the Node version CI runs on. Node 20 doesn't get this fix, so moving those workflows to Node 24 (or tonode-version-file: .nvmrc) is a separate follow-up.Testing
.nvmrc. Repo CI stays on Node 20, per the section above.npm ciand the productionnpm run webpackbuild succeeded, and Jest passed (3 suites, 10 tests).🤖 Generated with Claude Code