Skip to content

floret: add recipe for floret 0.10.5 - #1068

Open
varunsinghal29 wants to merge 1 commit into
openembedded:masterfrom
varunsinghal29:floret
Open

floret: add recipe for floret 0.10.5#1068
varunsinghal29 wants to merge 1 commit into
openembedded:masterfrom
varunsinghal29:floret

Conversation

@varunsinghal29

Copy link
Copy Markdown

Add a new recipe for floret, a fastText fork with Bloom embeddings for compact, full-coverage vectors compatible with spaCy. The recipe builds floret as a shared library, static library, and CLI binary using CMake, with zlib as a dependency.

Add a new recipe for floret, a fastText fork with Bloom embeddings
for compact, full-coverage vectors compatible with spaCy. The recipe
builds floret as a shared library, static library, and CLI binary
using CMake, with zlib as a dependency.

Signed-off-by: Varun Singhal <varusing@qti.qualcomm.com>

@kraj kraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Skip buildpaths/dev-elf QA on this recipe
# libs reference TMPDIR / are non-symlink .so
INSANE_SKIP:${PN} += "buildpaths"
INSANE_SKIP:${PN}-dev += "buildpaths dev-elf"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-elf is not needed with above fix.

install -m 0755 ${B}/libfloret.so ${D}${libdir}/libfloret.so.${PV}
ln -sf libfloret.so.${PV} ${D}${libdir}/libfloret.so.1
ln -sf libfloret.so.1 ${D}${libdir}/libfloret.so
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work.

CMake builds libfloret.so. and puts a libfloret.so symlink
next to it. Install the real library under its SONAME and recreate the
symlink: installing through the symlink instead would ship the same
library twice and leave ${libdir}/libfloret.so as an ELF file rather than
a link, which makes debian.bbclass rename ${PN}-dev to libfloret0 as
well as ${PN} - two packages with one name, which do_create_package_spdx
then dies on. you need something like below.

if [ -e ${B}/libfloret.so ]; then
    soname=$(${OBJDUMP} -p ${B}/libfloret.so | awk '/SONAME/ { print $2 }')
    install -m 0755 ${B}/libfloret.so ${D}${libdir}/$soname
    ln -sf $soname ${D}${libdir}/libfloret.so
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants