Repository navigation
Link a static call on a host interface without its missing glue - #445
Merged
Merged
Conversation
The fuzz job's cppia target stopped in CallStatic::link with "member call on null pointer of type 'hx::HaxeNativeClass'", on #442's run. A static call whose type had a host class looked the function up in that class's script glue, haxeBase, which a host interface does not have. Haxe gives an interface no statics, so only a malformed file makes such a call. It goes on to the field lookup the other host classes fall back to, and the file fails to load as for any other static that is not there.
The input from #442's fuzz run. Replayed with run.sh --replay cppia, main's loader segfaults on it and this branch's loads all ten cppia inputs.
# Conflicts: # Changes.md
28 of 34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzz job's cppia target stopped on #442's run (job):
#442 doesn't touch the loader, so the fuzzer just reached this there. A static call whose type has a host class looked the function up in the class's script glue,
haxeBase, which a host interface doesn't have. Haxe gives an interface no statics, so only a malformed file makes such a call. It now goes on to the field lookup the other host classes fall back to.The crashing input from that run is in
test/fuzz/regressions/cppia/static-call-on-a-host-interface. Replayed here withtest/fuzz/run.sh --replay cppia(MSVC x64), main's loader segfaults on it, and with this change all ten cppia inputs pass.