Skip to content

Commit 9e7aec0

Browse files
authored
msys2 improvements (#7976)
1 parent f437010 commit 9e7aec0

5 files changed

Lines changed: 27 additions & 20 deletions

File tree

.github/workflows/actions/build-msys2.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,11 @@ jobs:
4444
release: true
4545
update: false
4646
msystem: ${{matrix.msystem}}
47-
pacboy: gcc:p assimp:p cairo:p curl:p freeglut:p FreeImage:p glew:p glfw:p glm:p libsndfile:p libusb:p libxml2:p mpg123:p nlohmann-json:p openal:p opencv:p pugixml:p rtaudio:p uriparser:p utf8cpp:p
47+
pacboy: openssl:p python:p gcc:p assimp:p cairo:p curl:p freeglut:p FreeImage:p glew:p glfw:p glm:p libsndfile:p libusb:p libxml2:p mpg123:p nlohmann-json:p openal:p opencv:p pugixml:p rtaudio:p uriparser:p utf8cpp:p
4848
install: >-
4949
unzip
5050
make
51+
# lld
5152
# gcc:p gdb:p zlib:p poco:p pkgconf:p harfbuzz:p ntldd-git:p
5253
# boost:p tools:p
5354
# install: >-

.github/workflows/of.yml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,11 @@ jobs:
6969
release: true
7070
update: false
7171
msystem: ${{matrix.msystem}}
72-
pacboy: gcc:p assimp:p cairo:p curl:p freeglut:p FreeImage:p glew:p glfw:p glm:p libsndfile:p libusb:p libxml2:p mpg123:p nlohmann-json:p openal:p opencv:p pugixml:p rtaudio:p uriparser:p utf8cpp:p
72+
pacboy: openssl:p python:p gcc:p assimp:p cairo:p curl:p freeglut:p FreeImage:p glew:p glfw:p glm:p libsndfile:p libusb:p libxml2:p mpg123:p nlohmann-json:p openal:p opencv:p pugixml:p rtaudio:p uriparser:p utf8cpp:p
7373
install: >-
7474
unzip
7575
make
76+
# lld
7677
# gcc:p gdb:p zlib:p poco:p pkgconf:p harfbuzz:p ntldd-git:p
7778
# boost:p tools:p
7879
# install: >-
@@ -171,7 +172,7 @@ jobs:
171172
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
172173

173174
build-ios-tvos:
174-
runs-on: macos-13
175+
runs-on: macos-14
175176
strategy:
176177
matrix:
177178
cfg:
@@ -194,7 +195,7 @@ jobs:
194195
run: ./scripts/ci/$TARGET/build.sh;
195196

196197
env:
197-
DEVELOPER_DIR: "/Applications/Xcode_15.2.app/Contents/Developer"
198+
DEVELOPER_DIR: "/Applications/Xcode_15.4.app/Contents/Developer"
198199

199200

200201
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@@ -244,7 +245,7 @@ jobs:
244245
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
245246

246247
build-macos:
247-
runs-on: macos-13
248+
runs-on: macos-14
248249
strategy:
249250
matrix:
250251
cfg:
@@ -255,20 +256,11 @@ jobs:
255256
- name: ccache
256257
uses: hendrikmuhs/ccache-action@v1.2.13
257258
with:
258-
# key: ${{ matrix.os }}-${{ matrix.type }}
259259
key: ${{ matrix.cfg.target }}-${{ matrix.cfg.opt }}
260-
# key: ${{ matrix.msystem }}
261260

262261

263262
- name: Download libs
264-
# continue-on-error: true
265263
run: ./scripts/${{ matrix.cfg.target }}/download_libs.sh
266-
# - name: rm-dev
267-
# run: sudo rm -rf /Library/Developer
268-
269-
# this step is not needed here because the script is empty
270-
# - name: install
271-
# run: ./scripts/ci/$TARGET/install.sh
272264

273265
- name: Build
274266
run:
@@ -278,8 +270,8 @@ jobs:
278270
scripts/ci/${{ matrix.cfg.target }}/run_tests.sh;
279271
fi
280272
env:
281-
DEVELOPER_DIR: "/Applications/Xcode.app/Contents/Developer"
282-
SDKROOT: "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk"
273+
DEVELOPER_DIR: "/Applications/Xcode_15.4.app/Contents/Developer"
274+
SDKROOT: "/Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk"
283275

284276

285277
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

libs/openFrameworksCompiled/project/makefileCommon/compile.core.mk

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ ifdef PLATFORM_CXX
1313
CXX ?= $(PLATFORM_CXX)
1414
endif
1515

16+
1617
ifdef PROJECT_CC
1718
CC ?= $(PROJECT_CC)
1819
endif
@@ -21,6 +22,14 @@ ifdef PLATFORM_CC
2122
CC ?= $(PLATFORM_CC)
2223
endif
2324

25+
# ifdef PROJECT_LD
26+
# LD ?= $(PROJECT_LD)
27+
# endif
28+
29+
# ifdef PLATFORM_LD
30+
# LD = $(PLATFORM_LD)
31+
# endif
32+
2433
ifdef PROJECT_AR
2534
AR ?= $(PROJECT_AR)
2635
endif
@@ -29,6 +38,7 @@ ifdef PLATFORM_AR
2938
AR ?= $(PLATFORM_AR)
3039
endif
3140

41+
3242
ifdef PLATFORM_ARFLAGS
3343
ARFLAGS = $(PLATFORM_ARFLAGS)
3444
else
@@ -43,6 +53,7 @@ endif
4353

4454
$(info 💾 CXX = $(CXX))
4555
$(info 💾 CC = $(CC))
56+
# $(info 💾 LD = $(LD))
4657

4758
################################################################################
4859
# CFLAGS

libs/openFrameworksCompiled/project/makefileCommon/compile.project.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,11 +404,11 @@ $(OF_PROJECT_OBJ_OUTPUT_PATH)libs/openFrameworks/%.o: $(OF_ROOT)/libs/openFramew
404404

405405
# Rules to link the project
406406
$(TARGET): $(OF_PROJECT_OBJS) $(OF_PROJECT_RESOURCES) $(OF_PROJECT_ADDONS_OBJS) $(OF_PROJECT_LIBS) $(TARGET_LIBS) $(OF_PROJECT_OBJ_OUTPUT_PATH).compiler_flags
407-
@echo 'Linking $(TARGET) for $(ABI_LIB_SUBPATH)'
407+
@echo '🔗 Linking $(TARGET) for $(ABI_LIB_SUBPATH)'
408408
@mkdir -p $(@D)
409+
# $(LD)
409410
$(CXX) -o $@ $(OPTIMIZATION_LDFLAGS) $(OF_PROJECT_OBJS) $(OF_PROJECT_RESOURCES) $(OF_PROJECT_ADDONS_OBJS) $(TARGET_LIBS) $(OF_PROJECT_LIBS) $(LDFLAGS) $(OF_CORE_LIBS)
410411

411-
412412
clean:
413413
@$(MAKE) CleanDebug
414414
@$(MAKE) CleanRelease

libs/openFrameworksCompiled/project/msys2/config.msys2.default.mk

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
# core source code.
2626
##########################################################################################
2727

28-
MINGW_PREFIX ?= /mingw32
28+
#MINGW_PREFIX ?= /mingw32
29+
MINGW_PREFIX ?= /mingw64
2930
PLATFORM_CFLAGS += -std=gnu++17 -DUNICODE -D_UNICODE
3031
#PLATFORM_CFLAGS += -IC:/msys64/mingw32/include/gstreamer-1.0 -DOF_VIDEO_PLAYER_GSTREAMER
3132

@@ -34,7 +35,8 @@ CXX = $(MINGW_PREFIX)/bin/g++
3435

3536
FIND ?= /usr/bin/find
3637
PLATFORM_AR = $(MINGW_PREFIX)/bin/ar
37-
PLATFORM_LD = $(MINGW_PREFIX)/bin/ld
38+
#PLATFORM_LD = $(MINGW_PREFIX)/bin/ld
39+
PLATFORM_LD = /usr/bin/lld
3840
PLATFORM_RESOURCE_COMPILER = $(MINGW_PREFIX)/bin/windres
3941
PLATFORM_PKG_CONFIG = $(MINGW_PREFIX)/bin/pkgconf
4042

@@ -125,6 +127,7 @@ PLATFORM_CFLAGS += -fexceptions
125127
#PLATFORM_LDFLAGS += -arch i386
126128
PLATFORM_LDFLAGS += -lpthread
127129

130+
128131
ifeq ($(findstring MINGW64,$(MSYSTEM)),MINGW64)
129132
PLATFORM_LDFLAGS += -Wl,--disable-dynamicbase,--disable-high-entropy-va,--default-image-base-low
130133
endif

0 commit comments

Comments
 (0)