Skip to content

Add gulf of American & mexico - #5108

Open
lounnight wants to merge 2 commits into
openfrontio:mainfrom
lounnight:gulfofmexico
Open

Add gulf of American & mexico#5108
lounnight wants to merge 2 commits into
openfrontio:mainfrom
lounnight:gulfofmexico

Conversation

@lounnight

Copy link
Copy Markdown

Resolves #5081

Description:

Add gulf of American & mexico, I made it because gulfs maps are few
15 nations
"height": 908,
"num_land_tiles": 376998,
"width": 1336

Screenshot From 2026-08-22 21-57-02 Screenshot From 2026-08-22 22-08-58 Screenshot From 2026-08-22 22-15-55

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME: lounnight

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d7b209a-3bb1-459e-9b25-6b07254d5b6e

📥 Commits

Reviewing files that changed from the base of the PR and between ce94984 and 2fad0b0.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/gulfofamericaandmexico/image.png is excluded by !**/*.png
  • resources/maps/gulfofamericaandmexico/map.bin is excluded by !**/*.bin
  • resources/maps/gulfofamericaandmexico/map16x.bin is excluded by !**/*.bin
  • resources/maps/gulfofamericaandmexico/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (5)
  • map-generator/assets/maps/gulfofamericaandmexico/info.json
  • resources/lang/en.json
  • resources/maps/gulfofamericaandmexico/manifest.json
  • resources/maps/gulfofamericaandmexico/thumbnail.webp
  • src/core/game/Maps.gen.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

Adds the Gulf of America and Mexico map with metadata, dimensions, 15 nations, localization, and generated map registration.

Changes

Gulf of America and Mexico map

Layer / File(s) Summary
Map configuration and nation layout
map-generator/assets/maps/gulfofamericaandmexico/info.json, resources/maps/gulfofamericaandmexico/manifest.json
Adds map metadata, dimensions, translation identifiers, and 15 nation definitions with coordinates, strengths, and optional flags.
Map registration and localization
src/core/game/Maps.gen.ts, resources/lang/en.json
Registers the map as GulfOfAmericaandMexico, assigns the North America category and multiplayer frequency, and adds the English display name. Existing tribe arrays are reformatted without data changes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 2fad0

This PR adds the Gulf of America and Mexico map with its generated metadata and translation entry. Existing consistency checks cover the affected map integration, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: evanpelle, flopinguin, rickd004

Poem

Gulf waters meet the map
Nations find their numbered place
Flags rise by the shore
Names now speak in English
A new route joins the atlas

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The pull request reformats the customTribes arrays for the Germany, LosAngeles, and Sol maps in src/core/game/Maps.gen.ts. These changes are unrelated to adding the Gulf of Mexico map. Revert the unrelated customTribes formatting changes or move them into a separate pull request. Keep only the generated metadata required for the Gulf of America and Mexico map.
Linked Issues check ❓ Inconclusive The pull request adds the map configuration, manifest, translation entry, and generated map metadata for issue #5081. The geographic requirements cannot be verified because the relevant image and map … Review map-generator/assets/maps/gulfofamericaandmexico/image.png and the excluded map binary files to verify that the map includes the southern United States, Mexico, and Cuba, with the Gulf of Mexico as the central body of water.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Description check ✅ Passed The description explains the new Gulf map, its 15 nations, screenshots, tests, and linked issue. It is directly related to the changeset.
Title check ✅ Passed The title identifies the primary change: adding the Gulf of America and Mexico map. The wording has capitalization and naming errors, but it remains clear and related to the changeset.
Full details: Linked Issues check

Explanation

The pull request adds the map configuration, manifest, translation entry, and generated map metadata for issue #5081. The geographic requirements cannot be verified because the relevant image and map binary files are excluded by the !/*.png and !/*.bin filters.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Gulf of Mexico map

2 participants