Skip to content

test: add missing assertions for run functions #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dinesh-5445 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add missing assertions for run functions #1739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/test_runs/test_run_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ def _assert_predictions_equal(self, predictions, predictions_prime):
def _rerun_model_and_compare_predictions(self, run_id, model_prime, seed, create_task_obj):
run = openml.runs.get_run(run_id)

# TODO: assert holdout task
task = openml.tasks.get_task(run.task_id)
assert "Holdout" in task.estimation_procedure["type"]

# downloads the predictions of the old task
file_id = run.output_files["predictions"]
Expand Down Expand Up @@ -341,12 +342,12 @@ def _remove_random_state(flow):
assert isinstance(run.dataset_id, int)

# This is only a smoke check right now
# TODO add a few asserts here
assert len(run.parameter_settings) > 0
run._to_xml()
if run.trace is not None:
# This is only a smoke check right now
# TODO add a few asserts here
run.trace.trace_to_arff()
trace_arff = run.trace.trace_to_arff()
assert len(trace_arff["data"]) > 0

# check arff output
assert len(run.data_content) == num_instances
Expand Down Expand Up @@ -609,7 +610,7 @@ def determine_grid_size(param_grid):
create_task_obj=False,
)

# todo: check if runtime is present
assert "usercpu_time_millis" in run.fold_evaluations
self._check_fold_timing_evaluations(
fold_evaluations=run.fold_evaluations,
num_repeats=1,
Expand Down