Skip to content

Add missing assertions to run function tests - #1741

Open
Bhoomika910 wants to merge 1 commit into
openml:mainfrom
Bhoomika910:fix/1646-missing-assertions
Open

Bhoomika910 wants to merge 1 commit into
openml:mainfrom
Bhoomika910:fix/1646-missing-assertions

Conversation

@Bhoomika910

Copy link
Copy Markdown

Description

This PR addresses Issue #1646 by adding missing assertions to run function tests.

Changes

  • Added an assertion to verify that _to_xml() returns a string.
  • Added an assertion to verify that trace_to_arff() returns a dictionary.
  • Added an assertion to verify that downloaded runs contain parameter settings.
  • Added an assertion to verify that runtime is present in run attributes.

Testing

  • git diff --check passes.
  • Targeted tests were run.
  • One test involving the OpenML test server failed because the server returned a document_missing_exception for flow 42, resulting in an XML parsing error. This appears to be a test-server/environment issue rather than a failure caused by the added assertions.

Fixes #1646

@Bhoomika910

Copy link
Copy Markdown
Author

Hi maintainers,

I have implemented the missing assertions described in Issue #1646.

The changes add assertions for XML output, trace ARFF output, downloaded run parameter settings, and runtime attributes.

I also ran the relevant tests. One test-server-dependent test encountered a server-side document_missing_exception, which appears unrelated to these changes.

Thank you for reviewing the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Add Missing Assertions to Run Function Tests

2 participants