Add missing assertions to run function tests - #1741
Open
Bhoomika910 wants to merge 1 commit into
Open
Bhoomika910 wants to merge 1 commit into
Bhoomika910 wants to merge 1 commit into
Conversation
Author
|
Hi maintainers, I have implemented the missing assertions described in Issue #1646. The changes add assertions for XML output, trace ARFF output, downloaded run parameter settings, and runtime attributes. I also ran the relevant tests. One test-server-dependent test encountered a server-side document_missing_exception, which appears unrelated to these changes. Thank you for reviewing the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #1646 by adding missing assertions to run function tests.
Changes
_to_xml()returns a string.trace_to_arff()returns a dictionary.runtimeis present in run attributes.Testing
git diff --checkpasses.document_missing_exceptionfor flow 42, resulting in an XML parsing error. This appears to be a test-server/environment issue rather than a failure caused by the added assertions.Fixes #1646