Repository navigation
Apply the springfox-swagger2 upgrade from NoGuava again - #1286
Merged
Merged
Conversation
…Java11 HasJavaVersion never marks pom.xml or build.gradle, which carry no JavaVersion marker, so since NoGuavaJava11 gained its HasJavaVersion precondition the springfox upgrade could no longer edit build files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
springfox-swagger2upgrade added in f7b9ab3 lived inNoGuavaJava11's recipe list. Since #651 gated that recipe onHasJavaVersion: [11,), it can no longer editpom.xmlorbuild.gradle:HasJavaVersionjudges every file, and build files never carry aJavaVersionmarker, so they never pass the precondition. This moves the upgrade into the parentNoGuavarecipe list, which only hasSingleton; springfox 2.10 runs on Java 8, so it needs no Java version gate.NoGuavaJava11keepsHasJavaVersionrather than switching toHasMinimumJavaVersion: its code recipes need the per-file language level, andHasMinimumJavaVersiononly marks files at the repository's lowest version, so Java 17 modules next to Java 11 ones would lose the Guava to JDK rewrites.NoGuavaTest#upgradeSpringfoxThatStillUsesGuavaOptionalcovers thepom.xmlupgrade and fails without this change.