MigrateAssertionFailedError: leave source files using junit.framework.TestResult untouched

[mohitduhan19]

What's changed?

MigrateAssertionFailedError now has a DoesNotUseType precondition (with includeImplicit: true) on junit.framework.TestResult, so source files that use it are left untouched.

What's your motivation?

Follow-up to #1114 (the secondary MigrateAssertionFailedError point), as discussed in #1168.

TestResult.addFailure(Test, junit.framework.AssertionFailedError) only accepts the JUnit 3 type. Today the recipe retargets junit.framework.AssertionFailedError to org.opentest4j.AssertionFailedError everywhere in the file, including the cast passed into addFailure(..), so the argument type no longer matches and the file stops compiling. A class that reports to a TestResult is participating in the JUnit 3 execution model, consistent with #1168 which now leaves such TestCase subclasses untouched in MigrateJUnitTestCase.

Anything in particular you'd like reviewers to focus on?

The guard is per source file, matching #1168. includeImplicit: true also covers files that only reach TestResult through a method return type (e.g. createResult().addFailure(..)) without importing it.

Have you considered any alternatives or workarounds?

Only skipping the AssertionFailedError references that flow into addFailure(..). That would leave a mix of both exception types in one file, so skipping the whole file seemed simpler and safer.

Any additional context

Tests added:

• MigrateAssertionFailedErrorTest: a positive case (still migrated), the reproduction from MigrateJUnitTestCase rewrites super.run(TestResult) to Assertions.run(...), which does not exist #1114, and an implicit-only TestResult use; both negative cases fail without the change.
• JUnit5MigrationTest#leaveTestCaseReportingToTestResultUntouched: the MigrateJUnitTestCase rewrites super.run(TestResult) to Assertions.run(...), which does not exist #1114 reproduction under the full JUnit4to5Migration, which now leaves the file untouched (together with MigrateJUnitTestCase: leave TestCase subclasses overriding run(TestResult) untouched #1168).

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've run ./gradlew build locally, and committed any resulting changes to recipes.csv (no recipe names, descriptions or options changed, so recipes.csv should be unaffected; I ran the junit5 package tests locally and they pass, apart from the Gradle Tooling API tests that couldn't run in my environment)
• I've formatted the lines I changed, without reformatting code I didn't touch