Repository navigation
WireMock 4 migration: move Jetty EE10 to EE11 and bump to 4.0.0-beta.40 - #1184
Merged
Merged
Conversation
…beta.40 WireMock 3's `wiremock-jetty12` ran on Jetty EE10, whereas WireMock 4.x runs on EE11 (e.g. `NotFoundHandler` now takes an `ee11.servlet.ServletContextHandler`). Adding `jetty-ee10-webapp` left a mixed EE10/EE11 classpath, so instead move EE10 packages and dependencies to EE11 in modules depending on `wiremock-jetty12`, and add the runtime-only `jetty-ee11-webapp` / `jetty-ee11-servlets` modules when used directly. Also bump the pinned WireMock version to 4.0.0-beta.40, which is purely additive over beta.38. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sullis
force-pushed
the
wiremock4-jetty-ee11
branch
from
October 11, 2026 23:06
787b47c to
05f665d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
wiremock-jetty12ran on Jetty EE10, but WireMock 4.x (already as of beta.38) runs on EE11. For example,NotFoundHandler(...)now takes anorg.eclipse.jetty.ee11.servlet.ServletContextHandler. The previousjetty-ee10-webappAddDependencykept EE10 code compiling, but left a mixed EE10/EE11 classpath where EE10 objects can't be passed to WireMock APIs.MigrateJettyEe10ToEe11sub-recipe, run fromWiremock3to4Migrationbefore the WireMock dependency changes:org.eclipse.jetty.ee10packages toee11jetty-ee10-servlet/-servlets/-webappdependencies to their EE11 counterpartsjetty-ee11-webappandjetty-ee11-servletswhen they're used, since WireMock 4 only puts them on the runtime classpath. These match on theee10packages becauseAddDependencychecksonlyIfUsingagainst the sources as they were beforeChangePackageran.wiremock-jetty12, where EE10 came in through WireMock. Modules with their own unrelated Jetty EE10 usage are left alone.jetty-ee10-webappAddDependency.4.0.0-beta.38→4.0.0-beta.40. I compared the class lists ofwiremock-core,-jetty,-httpclient-apache5,-url,-junit4and-junit5: beta.40 only adds classes, and everyChangeTypetarget still exists.Tests
New cases in
Wiremock3to4MigrationTest:jettyEe10MovesToEe11AlongsideWiremockJetty12: EE10 imports and dependencies move to EE11 when the module useswiremock-jetty12.jettyEe11WebappAddedWhenEe10OnlyCameThroughWiremockJetty12:jetty-ee11-webappis added when EE10 was only available transitively through WireMock.jettyEe10UntouchedWithoutWiremockJetty12: modules withoutwiremock-jetty12keep their EE10 code and dependencies.These tests haven't run yet. The build resolves its Gradle plugins and
rewrite-*jars fromartifacts.codegenomeproject.org, which returns HTTP 401 without credentials. That fails both locally and in this PR's CI run, during project configuration and before any tests start. A maintainer may need to re-run CI with credentials.recipes.csvdoesn't have a row forMigrateJettyEe10ToEe11yet; it may need regenerating.🤖 Generated with Claude Code