Repository navigation
Add mockito-junit-jupiter when PowerMockRunner becomes MockitoExtension - #1185
Merged
Merged
Conversation
UseMockitoExtension only added mockito-junit-jupiter when the scanner saw a MockitoJUnit*Runner, but in PowerMock projects ReplacePowerMockito turns PowerMockRunner into MockitoJUnitRunner.Silent in the same cycle, so the dependency was never added within the cycles a production run performs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseMockitoExtensiononly addedmockito-junit-jupiterwhen its scanner saw aMockitoJUnit*Runner, but in PowerMock projectsReplacePowerMockitorewrites@RunWith(PowerMockRunner.class)toMockitoJUnitRunner.Silentand then@ExtendWith(MockitoExtension.class)within the same cycle, so the dependency was never added (seen in five Capital One repositories).This adds a second
AddDependencykeyed onorg.powermock.modules.junit4.PowerMockRunner; keying it onorg.mockito.junit.jupiter..*instead would rely on a second cycle that does not happen whenmockito-coreis already declared.The regression test runs
JUnit4to5Migrationwith production cycle limits (recipe.run(sources, ctx, 3, 1)) and asserts the resulting pom, which now matches what a plainMockitoJUnitRunnerproject gets.