Repository navigation
Override a Spring Boot BOM-managed Mockito when replacing PowerMock - #1186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under a Spring Boot 2.2–2.3 parent,
ReplacePowerMockitoleft Mockito at the BOM-managed 3.3.3, soMockedStaticandMockedConstructiondid not resolve.UpgradeMockitoCoreReplacingPowerMocknow setsoverrideManagedVersion: true, which overrides the BOM'smockito.versionproperty so the whole Mockito family moves to 3.12.4, and runs afterReplacePowerMockDependenciesso it also upgrades themockito-inlineadded without a version. Themockito-alltomockito-corerename moves into a newChangeMockitoAllToMockitoCoreReplacingPowerMockthat still runs first, so no secondmockito-coregets added. New tests cover the Boot 2.3.12 parent with and without a local<mockito.version>and assert the resolved versions on theMavenResolutionResultmarker. A<mockito.version>set in a local multi-module parent is still not raised, andUpgradeTransitiveDependencyVersionis left out because its downgrade guard only looks at compile scope, so it pins a test-scoped Mockito 5 down to 3.x.