Repository navigation
Keep WireMockRule used as a server a WireMockServer; port() to getPort() - #1187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseWiremockExtensionturns everyWireMockRuleinto aWireMockExtension, which breaks tests that callstart(),stop(),isRunning()orport()on it, asWireMockRuleextendsWireMockServer.The new
WireMockRuleToWireMockServerrecipe, run before it inJUnit4to5Migration, keeps a rule that is used with server lifecycle methods or passed on as aWireMockServeras a plainWireMockServer, started and stopped in@BeforeEach/@AfterEach(or static@BeforeAll/@AfterAllfor a@ClassRule), reusing existing lifecycle methods where present.It scans all sources, so a rule declared in a base class and stopped in a subclass is caught as well.
UseWiremockExtensionnow also rewritesport()andhttpsPort()on the remaining rules togetPort()andgetHttpsPort().Tests cover both paths, standalone and through
JUnit4to5Migration.