Repository navigation
Harden producer dispatch and administrative API authentication - #2
Merged
Merged
Conversation
Generate timestamps at an explicitly configured input rate for HTTP JPEG and MJPEG transcoding sources. Validate the value and document the new framerate query parameter.\n\nRefs opensensor/lightNVR#588.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Producer redirects and config-file streams could bypass source validation, and FFmpeg commands were assembled as text before execution. Apply validation at configuration load, registration, and every producer dispatch; launch FFmpeg through a separate argument-vector path with validated source parameters. Require credentials for config, restart, and exit endpoints even on loopback, disabling them when credentials are absent. Bind the API to loopback by default.
Compatibility: raw FFmpeg command fragments, local file/device inputs, and arbitrary filter/query parameters are rejected. Supported network sources, stream references, codec presets, and validated synthetic test patterns remain available. This branch also preserves the HTTP input-framerate commit already pinned by LightNVR but not yet merged into
dev.Validation:
Companion PR: opensensor/lightNVR#668 updates the submodule pin, container defaults, browser routing, and authenticated reverse-proxy documentation. Merge this PR first; the LightNVR PR pins commit
41c9dfd38c513d73a8265259dcda19a1932f6174, so retain that commit in the merge history or update the companion pin after merging.