Skip to content

OCPBUGS-74510: Remove VSphereMultiDisk feature gate #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vr4manta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-74510: Remove VSphereMultiDisk feature gate #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,5 +124,4 @@
| UpgradeStatus| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereHostVMGroupZonal| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMixedNodeEnv| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMultiDisk| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMultiNetworks| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
7 changes: 0 additions & 7 deletions features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,6 @@ var (
enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateVSphereMultiDisk = newFeatureGate("VSphereMultiDisk").
reportProblemsToJiraComponent("splat").
contactPerson("vr4manta").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1709").
enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateRouteExternalCertificate = newFeatureGate("RouteExternalCertificate").
reportProblemsToJiraComponent("router").
Expand Down
1 change: 0 additions & 1 deletion machine/v1beta1/types_vsphereprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ type VSphereMachineProviderSpec struct {
// dataDisks is a list of non OS disks to be created and attached to the VM. The max number of disk allowed to be attached is
// currently 29. The max number of disks for any controller is 30, but VM template will always have OS disk so that will leave
// 29 disks on any controller type.
// +openshift:enable:FeatureGate=VSphereMultiDisk
// +optional
// +listType=map
// +listMapKey=name
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
}
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
},
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
}
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
},
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
}
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
},
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
}
Expand Down
3 changes: 0 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@
{
"name": "VSphereMixedNodeEnv"
},
{
"name": "VSphereMultiDisk"
},
{
"name": "VSphereMultiNetworks"
},
Expand Down