OCPBUGS-96412: Move ec2 volume attach/detach to unscoped section#1049
OCPBUGS-96412: Move ec2 volume attach/detach to unscoped section#1049dlom wants to merge 1 commit into
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@dlom: This pull request references Jira Issue OCPBUGS-96412, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR reclassifies the AWS IAM actions ChangesIAM action tag-scope reclassification
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira refresh |
openshift-ci
Bot
added
the
approved
openshift-ci-robot
added
jira/valid-bug
|
@dlom: This pull request references Jira Issue OCPBUGS-96412, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 5.0 nightly informing |
|
@dlom: trigger 69 job(s) of type informing for the nightly release of OCP 5.0
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce562270-759e-11f1-87c7-baee85f1f048-0 |
|
@dlom: This pull request references Jira Issue OCPBUGS-96412, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/security |
|
@dlom: Overrode contexts on behalf of dlom: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
+ Coverage 47.33% 48.81% +1.48%
==========================================
Files 97 97
Lines 12613 13006 +393
==========================================
+ Hits 5970 6349 +379
- Misses 5987 5994 +7
- Partials 656 663 +7
🚀 New features to boost your workflow:
|
|
/verified by periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-upi |
|
/assign @JoelSpeed |
openshift-ci-robot
added
the
verified
|
@dlom: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dlom: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
xref: OCPBUGS-96412
followup for OCPBUGS-87829
Summary by CodeRabbit
AttachVolumeandDetachVolumenow follow the correct unscoped behavior, preventing unexpected policy matches when related resources don’t share the same ownership tag.