CNV-86243: Move all HCO related documentation to API version v1#114268
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@nunnatsa: This pull request references CNV-86243 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/XL
|
🤖 Mon Jun 29 13:13:04 - Prow CI generated the docs preview: |
nunnatsa
force-pushed
the
hco-mv-to-v1-api
branch
2 times, most recently
from
2c58300 to
d540f09
Compare
| "allowApplicationAwareClusterResourceQuota": true | ||
| "deployment": { | ||
| "applicationAwareConfig": { | ||
| "enabled": true, |
| ---- | ||
| $ oc patch {HCOCliKind} kubevirt-hyperconverged -n {CNVNamespace} --type json -p \ | ||
| "[{\"op\":\"add\",\"path\":\"/spec/workloadUpdateStrategy/workloadUpdateMethods\", \"value\":{WorkloadUpdateMethodConfig}}]" | ||
| '[{"op":"add","path":"spec/virtualization/workloadUpdateStrategy/workloadUpdateMethods", "value":{WorkloadUpdateMethodConfig}}]' |
There was a problem hiding this comment.
| '[{"op":"add","path":"spec/virtualization/workloadUpdateStrategy/workloadUpdateMethods", "value":{WorkloadUpdateMethodConfig}}]' | |
| '[{"op":"add","path":"/spec/virtualization/workloadUpdateStrategy/workloadUpdateMethods", "value":{WorkloadUpdateMethodConfig}}]' |
| spec: | ||
| featureGates: | ||
| declarativeHotplugVolumes: true | ||
| - name: declarativeHotplugVolumes |
There was a problem hiding this comment.
nit: the fg indenet should be 2 speced back isn't it?
nunnatsa
force-pushed
the
hco-mv-to-v1-api
branch
from
d540f09 to
8bc2af2
Compare
hmeir
left a comment
hmeir
left a comment
There was a problem hiding this comment.
Few Missed files:
Text references to old HCO field paths:
-
modules/virt-about-workload-updates.adoc(line 17)
spec.workloadUpdateStrategy→spec.virtualization.workloadUpdateStrategy -
modules/virt-about-ksm.adoc(line 21)
spec.configuration.ksmConfiguration→spec.virtualization.ksmConfiguration -
modules/virt-about-aaq-operator.adoc(line 44)
spec.applicationAwareConfig.allowApplicationAwareClusterResourceQuota→spec.deployment.applicationAwareConfig.allowApplicationAwareClusterResourceQuota -
modules/virt-about-aaq-operator.adoc(line 80)
spec.namespaceSelector→spec.deployment.applicationAwareConfig.namespaceSelector -
modules/virt-ibm-z-compatibility.adoc(line 44)
spec.defaultCPUModel→spec.virtualization.virtualMachineOptions.defaultCPUModel
Old feature gate format:
modules/proc_virt-creating-vcp-vms.adoc(lines 38-40)
Old:{"featureGates": {"declarativeHotplugVolumes": true}}
New:{"featureGates": [{"name": "declarativeHotplugVolumes"}]}
nunnatsa
force-pushed
the
hco-mv-to-v1-api
branch
2 times, most recently
from
fcd9b03 to
442c3cb
Compare
Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
nunnatsa
force-pushed
the
hco-mv-to-v1-api
branch
from
442c3cb to
c118b40
Compare
|
@nunnatsa: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM! Thank you for doing this, @nunnatsa |
|
/cherrypick enterprise-5.0 |
|
@ousleyp: new pull request created: #114301 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Version(s): v5.0, v4.23
Issue: https://redhat.atlassian.net/browse/CNV-86243
Link to docs preview:
QE review:
Additional information: