OCPBUGS-98719: retry GetVotingMemberNames on transient etcd client fails - #31445
OCPBUGS-98719: retry GetVotingMemberNames on transient etcd client fails#31445IlanZuckerman wants to merge 2 commits into
Conversation
…ilures `GetVotingMemberNames` previously failed immediately when `NewEtcdClient` or `MemberList` errored, which is flaky during master replacement while etcd is restarting and port-forwards drop. Poll and retry those transient errors instead of failing the CPMS OnDelete scaling test on the first attempt.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
jira/severity-moderate
|
@IlanZuckerman: This pull request references Jira Issue OCPBUGS-98719, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
IlanZuckerman
changed the title
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
Changesetcd member discovery
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
That log was already there before My PR. The same pattern is used all over these etcd helpers (EnsureVotingMembersCount, EnsureVotingMembersExcluding) |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
file="test/extended/etcd/helpers/helpers.go"
echo "== Relevant declarations =="
ast-grep outline "$file" --items all --type function --match 'GetVotingMemberNames|EnsureVotingMembersCount|EnsureVotingMembersExcluding' --view expanded || true
echo
echo "== Relevant log statements and function context on PR branch =="
rg -n -C 8 'func (GetVotingMemberNames|EnsureVotingMembersCount|EnsureVotingMembersExcluding)\b|framework\.Logf' "$file"
echo
echo "== PR merge base and changed hunks =="
base="$(git merge-base HEAD origin/master 2>/dev/null || git merge-base HEAD origin/main 2>/dev/null || true)"
if [ -z "$base" ]; then
echo "Could not determine merge base against origin/master or origin/main." >&2
exit 1
fi
echo "Merge base: $base"
git diff --unified=20 "$base"...HEAD -- "$file"Length of output: 15246
This sensitive-log finding is out of scope for this change, so I’m withdrawing it. ✏️ Learnings added
|
|
Tip For best results, initiate chat on the files or code changes.
Withdrawing this finding. |
|
Tip For best results, initiate chat on the files or code changes.
Withdrawing this finding. |
|
Scheduling required tests: |
/retest |
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@IlanZuckerman: This pull request references Jira Issue OCPBUGS-98719, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This fix should be back ported to to 4.19 → 4.23. I will do so after the initial CR. |
|
/jira backport release-4.23,release-4.22,release-4.21,release-4.20,release-4.19 |
|
@IlanZuckerman: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| for _, member := range memberList.Members { | ||
| if !member.IsLearner { | ||
| votingMemberNames = append(votingMemberNames, member.Name) | ||
| memberCtx, cancel := context.WithTimeout(ctx, 15*time.Second) |
There was a problem hiding this comment.
parameter representing timeout in seconds probably should be defined as a variable just like waitPollTimeout, to be coherent with the call in line 453.
There was a problem hiding this comment.
Thanks @gryf , that makes sense. I added a new var memberListTimeout
gryf
left a comment
gryf
left a comment
There was a problem hiding this comment.
Mostly it is looking good, just one remark.
|
@IlanZuckerman: This pull request references Jira Issue OCPBUGS-98719, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ekuris-redhat, gryf, IlanZuckerman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
/retest |
|
@IlanZuckerman: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
GetVotingMemberNamespreviously failed immediately whenNewEtcdClientorMemberListerrored, which is flaky during master replacement while etcd is restarting and port-forwards drop.Poll and retry those transient errors instead of failing the CPMS OnDelete scaling test on the first attempt.
Summary by CodeRabbit