kube-vip: project onboarding#80926
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThis PR adds initial CI operator, Prow plugin, Tide, and OWNERS configuration for ChangesKube-VIP onboarding
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/prow/02_config/openshift/kube-vip/_pluginconfig.yaml`:
- Around line 9-12: The plugins section for openshift/kube-vip in the
_pluginconfig.yaml file currently only includes the `approve` plugin, but the
Tide configuration requires the `lgtm` plugin to be enabled as well. Add `lgtm`
to the plugins list under the openshift/kube-vip configuration alongside the
existing `approve` plugin to enable the normal `/lgtm` labeling workflow.
In `@core-services/prow/02_config/openshift/kube-vip/_prowconfig.yaml`:
- Around line 99-104: The excludedBranches list does not include community-4.6
and community-4.7, which creates an overlap since these branches are already
included in a stricter query elsewhere. Add community-4.6 and community-4.7 to
the excludedBranches list in the catch-all query to prevent merges from going
through the weaker label set. Apply the same fix to both occurrences of this
pattern in the file (at lines 99-104 and also at lines 150-154).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4e5f44e3-cb1e-458d-b861-185fd1fe1796
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/kube-vip/openshift-kube-vip-main.yamlcore-services/prow/02_config/openshift/kube-vip/_pluginconfig.yamlcore-services/prow/02_config/openshift/kube-vip/_prowconfig.yaml
|
@mkowalski: |
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
/pj-rehearse help |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Onboard the openshift/kube-vip repository for testing and merge automation: - ci-operator config (openshift-kube-vip-main.yaml) with unit-tests and integration-tests run from the src image, built with the rhel-9-release-golang-1.26-openshift-5.0 build root. - Generated presubmit Prow jobs. - Prow plugin config (approve) and trimmed Tide config (openshift-4.22 / release-4.22 onward, plus main/master). - OWNERS files for the ci-operator config and jobs directories, mirroring the component repo's root OWNERS. The config is CI-testing-only for now; payload promotion and an images stanza can be added once the component is onboarded to ART.
|
@mkowalski: job(s): help either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse ? |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
mkowalski
force-pushed
the
kube-vip-onboarding
branch
from
1cacbd4 to
40abb81
Compare
|
@mkowalski: job(s): ? either don't exist or were not found to be affected, and cannot be rehearsed |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
This PR onboards the
openshift/kube-viprepository into OpenShift’s CI and Prow/Tide workflows so PRs receive automated CI coverage and follow consistent merge/labeling rules.ci-operator/config/openshift/kube-vip/openshift-kube-vip-main.yaml). The configuration specifies the build root image stream/tag, sets default container CPU/memory requests and limits, defines the test command (go test -race ./...), and configures two CI phases that run in thesrccontainer context:unit-tests:make unit-testsintegration-tests:make integration-testscore-services/prow/02_config/openshift/kube-vip/_pluginconfig.yaml) that enables standardapprovehandling while treating reviews withreview_acts_as_lgtm: trueas LGTM.core-services/prow/02_config/openshift/kube-vip/_prowconfig.yaml) defining branch-specific label requirements and missing-label expectations for PRs targetingopenshift-4.22/release-4.22vsmain/master, along with a set of excluded branches that apply a narrower approval/label policy.core-services/prow/02_config/openshift/kube-vip/OWNERSwith explicitreviewersandapproversfor the repo.In practical terms, kube-vip PRs will now run OpenShift-managed unit and integration tests in CI and will be governed by repo-specific Prow/Tide approval and labeling rules.