kube-apiserver cert rotation job addition#80948
Conversation
This is added as cert rotation job based on PKI key size is disruptive and cannot be part existing e2e job as it affects the run of few tests there. Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughA new optional CI test job ChangesCert-rotation disruptive e2e job
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kaleemsiddiqu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
not added additional job try first run with conformance tech preview jobs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaleemsiddiqu, oceanc80 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is added as cert rotation job based on PKI key size is disruptive and cannot be part existing e2e job as it affects the run of few tests there.
Summary by CodeRabbit
This PR adds a new disruptive certificate rotation test job to the CI configuration for the OpenShift kube-apiserver operator. The change modifies
ci-operator/config/openshift/cluster-kube-apiserver-operator/openshift-cluster-kube-apiserver-operator-main.yamlto include a new optional test entry namede2e-gcp-operator-cert-rotation-disruptive.The new test job:
openshift-org-gcp)run_if_changed) when changes are made to certificate rotation or PKI-related code paths, including:test/e2e-cert-rotation-disruptive)pkg/operator/certrotationcontroller,pkg/cmd/certregenerationcontroller)vendor/github.com/openshift/library-go/pkg/crypto,vendor/github.com/openshift/library-go/pkg/operator/certrotation,vendor/github.com/openshift/library-go/pkg/pki)vendor/github.com/openshift/api/config/v1alpha1/.*pki)openshift/cluster-kube-apiserver-operator/cert-rotation-disruptivetest suite using the standardopenshift-e2e-testreference andipi-gcpworkflowThis dedicated, optional test job allows OpenShift CI to validate certificate rotation behavior in isolation, since the certification rotation process is disruptive and interferes with other concurrent tests if integrated into existing workflows.