Skip to content

MGMT-24327: upgrade assisted-service postgresql from 15 to 16#80951

Open
zszabo-rh wants to merge 1 commit into
openshift:mainfrom
zszabo-rh:MGMT-24327/add-postgresql-16-c9s-mirroring
Open

MGMT-24327: upgrade assisted-service postgresql from 15 to 16#80951
zszabo-rh wants to merge 1 commit into
openshift:mainfrom
zszabo-rh:MGMT-24327/add-postgresql-16-c9s-mirroring

Conversation

@zszabo-rh

@zszabo-rh zszabo-rh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Update assisted-service CI configuration to use postgresql-16-c9s
instead of postgresql-15-c9s:

  • Update base_images and operator substitutions in master edge config
  • Add postgresql-16-c9s to image mirroring config

See also: assisted-service PR will follow after this merges.

https://issues.redhat.com/browse/MGMT-24327

Summary by CodeRabbit

This updates the assisted-service CI infrastructure to use PostgreSQL 16 c9s images instead of PostgreSQL 15. The assisted-service edge CI configuration now pulls and substitutes postgresql-16-c9s, and the shared image mirroring config was expanded so CI can mirror the new PostgreSQL 16 image for use in assisted-service jobs.

Add PG16 sclorg image to CI mirroring and update the assisted-service
edge CI config to use postgresql-16-c9s.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@zszabo-rh: This pull request references MGMT-24327 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update assisted-service CI configuration to use postgresql-16-c9s
instead of postgresql-15-c9s:

  • Update base_images and operator substitutions in master edge config
  • Add postgresql-16-c9s to image mirroring config

See also: assisted-service PR will follow after this merges.

https://issues.redhat.com/browse/MGMT-24327

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2026
@openshift-ci openshift-ci Bot requested review from adriengentil and psalajova June 24, 2026 05:54
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zszabo-rh
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e9ef06b0-eef3-4f35-b9af-412567ecccba

📥 Commits

Reviewing files that changed from the base of the PR and between 55724a4 and e0f1382.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml
  • core-services/image-mirroring/_config.yaml

Walkthrough

The PR upgrades the PostgreSQL CI image from version 15 (postgresql-15-c9s) to version 16 (postgresql-16-c9s) in the assisted-service edge CI operator configuration, updating both the base image reference and the operator bundle substitution pullspec. The new image is also registered in the central image mirroring configuration.

Changes

PostgreSQL 15→16 upgrade for assisted-service edge CI

Layer / File(s) Summary
Register postgresql-16-c9s in image mirroring config
core-services/image-mirroring/_config.yaml
Adds a new supplementalCIImages entry mapping ci/postgresql:postgresql-16-c9s to quay.io/sclorg/postgresql-16-c9s:latest.
Update assisted-service edge CI config
ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml
Replaces the postgresql base image tag from postgresql-15-c9s to postgresql-16-c9s and updates the operator bundle substitution pullspec accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

Suggested reviewers

  • droslean
  • danilo-gemoli
  • deepsm007
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading assisted-service PostgreSQL from 15 to 16.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Go/Ginkgo test files were changed; the PR only updates CI/image-mirroring YAML, so no test titles were introduced or modified.
Test Structure And Quality ✅ Passed PR only changes CI YAML/image-mirroring config; no Ginkgo test files or test logic were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added or modified; the PR only updates CI image-mirroring and assisted-service YAML config.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only updates CI/image-mirroring YAML for PostgreSQL 16; no new Ginkgo tests or SNO-relevant assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI/image-mirroring YAML changed; no pod scheduling fields, node selectors, affinities, spreads, or replica logic were added.
Ote Binary Stdout Contract ✅ Passed PR only changes YAML CI/image-mirroring configs; no Go/test binaries or process-level stdout code were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI YAML changed; no new Ginkgo tests or IPv4/networking code were added, so the check is not applicable.
No-Weak-Crypto ✅ Passed Only CI/image-mirroring YAML changed to PostgreSQL 16; no weak-crypto algorithms, custom crypto, or secret-comparison code present.
Container-Privileges ✅ Passed Touched files only swap postgres image tags/mirroring; no privileged, hostPID/Network/IPC, runAsUser 0, or allowPrivilegeEscalation:true settings were found.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR only updates CI image references; it adds no new logging and no secret/token/password values are emitted.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zszabo-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-service-master-edge-assisted-operator-catalog-publish-verify openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-ci-index openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-3masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-4masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-5masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-compact-day2-masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-compact-day2-workers openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-disconnected openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-multiarch-3masters-ocp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-multiarch-sno-ocp openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-node-labels openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-remove-node openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-masters openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-16 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-17 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-control-planes-5-0 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-masters-none-5-0 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-5-0 openshift/assisted-service presubmit Ci-operator config changed
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-5-control-planes-5-0 openshift/assisted-service presubmit Ci-operator config changed

A total of 82 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zszabo-rh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@zszabo-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@zszabo-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/assisted-service/master/edge-ci-index e0f1382 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-edge-ci-index
ci/rehearse/openshift/assisted-service/master/edge-e2e-ai-operator-ztp e0f1382 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
ci/rehearse/openshift/assisted-service/master/edge-e2e-ai-operator-disconnected-capi e0f1382 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi
ci/rehearse/openshift/assisted-service/master/edge-e2e-ai-operator-ztp-3masters e0f1382 link unknown /pj-rehearse pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-3masters

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zszabo-rh

Copy link
Copy Markdown
Contributor Author

Rehearsal failures are expected — all 4 jobs fail on the same cause:

step [input:postgresql-16-c9s] failed: "quay.io/openshift/ci:ci_postgresql_postgresql-16-c9s" not found

The image mirroring for postgresql-16-c9s is part of this PR. Until it merges, the CI mirror doesn't have the image, so rehearsals that reference it will fail. This is the same chicken-and-egg as the previous PG15 mirroring PR (#77242).

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@zszabo-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants