Skip to content

Ppt/vsphere cluster#80952

Open
ptalgulk01 wants to merge 2 commits into
openshift:mainfrom
ptalgulk01:ppt/vsphere_cluster
Open

Ppt/vsphere cluster#80952
ptalgulk01 wants to merge 2 commits into
openshift:mainfrom
ptalgulk01:ppt/vsphere_cluster

Conversation

@ptalgulk01

@ptalgulk01 ptalgulk01 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates the OpenShift verification test CI jobs for vSphere in the openshift/verification-tests configuration. It shortens the sleep/wait duration for installer rehearse workflows, which should make these CI runs complete sooner. For the 4.20 rehearsal job, it also pins the installer to a specific nightly release image override, ensuring the test runs against that exact build.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 92bbc900-98ca-4f61-ab32-3228df73946b

📥 Commits

Reviewing files that changed from the base of the PR and between beda1a6 and 08d0923.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/verification-tests/openshift-verification-tests-main__installer-rehearse-4.20.yaml
  • ci-operator/config/openshift/verification-tests/openshift-verification-tests-main__installer-rehearse-4.21.yaml

Walkthrough

Two CI job configuration files for installer-rehearse-vsphere are updated: the 4.20 config adds a CUSTOM_OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE pointing to a specific nightly release image and reduces SLEEP_DURATION from 24h to 8h; the 4.21 config reduces SLEEP_DURATION from 24h to 12h.

Changes

VSphere installer-rehearse environment variable updates

Layer / File(s) Summary
SLEEP_DURATION and release image override adjustments
ci-operator/config/openshift/verification-tests/openshift-verification-tests-main__installer-rehearse-4.20.yaml, ci-operator/config/openshift/verification-tests/openshift-verification-tests-main__installer-rehearse-4.21.yaml
Adds CUSTOM_OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE for the 4.20.0-0.nightly-2026-06-23-114525 image in the 4.20 vsphere job and reduces its SLEEP_DURATION from 24h to 8h; reduces SLEEP_DURATION from 24h to 12h in the 4.21 vsphere job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references vSphere, but "Ppt" is unclear and it does not describe the actual CI job timing changes. Use a clear title like "Adjust installer-rehearse vSphere job sleep durations" to reflect the main change.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes ci-operator YAML env vars for installer-rehearse-vsphere; no Ginkgo titles (It/Describe/Context/When) were added or modified.
Test Structure And Quality ✅ Passed Only ci-operator YAML job config changed; no Ginkgo test code or Go files were touched, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML env changes were made; no new Ginkgo It/Describe/Context tests or MicroShift-unsafe APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML env changes were made; no new Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates ci-operator test YAMLs (sleep/release image env); no deployment manifests, controllers, or scheduling constraints changed.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML for vSphere rehearse jobs; no Go/main/TestMain code was modified, so no OTE stdout contract risk.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI job env values changed in installer-rehearse YAMLs; no new Ginkgo tests, IPv4 assumptions, or external connectivity were added.
No-Weak-Crypto ✅ Passed Changed files are ci-operator YAML only; diff updates release image and SLEEP_DURATION. No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto found.
Container-Privileges ✅ Passed The PR only changes ci-operator job env values for vSphere; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes vSphere test env values (release image override and sleep duration); no passwords, tokens, PII, or other sensitive strings were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ptalgulk01
Once this PR has been reviewed and has the lgtm label, please assign pruan-rht for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from dis016 and pruan-rht June 24, 2026 06:48
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ptalgulk01: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-main-installer-rehearse-4.20-installer-rehearse-vsphere N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-vsphere N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ptalgulk01

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-main-installer-rehearse-4.20-installer-rehearse-vsphere

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ptalgulk01: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@ptalgulk01: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-main-installer-rehearse-4.20-installer-rehearse-vsphere 08d0923 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-main-installer-rehearse-4.20-installer-rehearse-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant