CM-716: Add baremetal e2e CI job for cert-manager-operator - #81902
CM-716: Add baremetal e2e CI job for cert-manager-operator#81902sebrandon1 wants to merge 2 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds an optional ChangesCert-manager operator e2e coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml`:
- Around line 326-327: Add an explicit 10-minute timeout to the oc wait
invocation for deployment cert-manager-operator-controller-manager, preserving
its existing Available condition and namespace arguments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 935b2875-6109-4ceb-a71d-b76de8fa422a
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml
c06cce0 to
ec01eea
Compare
openshift-ci
Bot
added
the
needs-rebase
|
@sebrandon1: This pull request references CM-716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@sebrandon1, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
ec01eea to
4a38041
Compare
openshift-ci
Bot
removed
the
needs-rebase
4a38041 to
25081ab
Compare
|
/rebase |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse auto-ack |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
25081ab to
da6fe8c
Compare
|
New changes are detected. LGTM label has been removed. |
|
Rebased against upstream/main. Resolved a merge conflict in |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
da6fe8c to
b291501
Compare
openshift-ci
Bot
added
the
needs-rebase
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@sebrandon1, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
b291501 to
adb2d56
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
adb2d56 to
f2999b1
Compare
|
@sebrandon1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
f2999b1 to
a019316
Compare
The oc wait command for the cert-manager-operator deployment was using the default 30s timeout, which can be too short for operator startup. Add --timeout=5m consistent with other oc wait calls in the file.
|
@sebrandon1: |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
3 participants
Summary
e2e-operator-metal-ipipre-submit job foropenshift/cert-manager-operatorbaremetalds-e2eworkflow,equinix-ocp-metalprofile)operator-sdk run bundleand runsPlatform:Generice2e testsalways_run: false+optional: true— triggered on-demand via/test e2e-operator-metal-ipiRelated PRs
Jira
Upstream References
Test Plan
e2e-operator-metal-ipirehearsal to validate baremetal provisioning and operator installoperator-sdk run bundlecompletes and controller-manager reaches AvailablePlatform:Generice2e tests pass on baremetal clusterSummary by CodeRabbit
Adds optional CI coverage for
openshift/cert-manager-operator.The
e2e-operator-metal-ipipre-submit job provisions an Equinix bare-metal cluster withbaremetalds-e2e, installs the operator bundle, verifies controller-manager availability, and runs filteredPlatform:Genericend-to-end tests. Developers can trigger it with/test e2e-operator-metal-ipi.The configuration also adds an optional
tls-scannerjob that enables TrustManager, validates a TrustManager resource, and scans TLS 1.3 adherence.