Make e2e-aws-openshift-node-compliance optional for ComplianceAsCode PRs - #82565
Conversation
The lane has failed on effectively every run since 2026-07-17 across both ComplianceAsCode/content and ComplianceAsCode/ocp4e2e pull requests, for reasons unrelated to the changes under test: - when the cluster installs, the full-remediation node test times out waiting for MachineConfigPools (~590 remediations reboot every node; the master pool rolls serially and the 60-minute wait sits at the expected duration - e.g. content#14878, ocp4e2e#78 runs); - other runs die earlier in ipi-install-install (AWS installer infra). As a required job this blocks merges repo-wide while providing no usable signal. Keep always_run so the signal stays visible, but stop gating merges on it until it is stabilized. Reliability fixes for the underlying timeout are proposed in ComplianceAsCode/ocp4e2e#82 (raise the MCP wait to 120min, fix a MaxUnavailable bug that serialized worker reboots, add rollout diagnostics); intent is to make the job required again once the lane holds green. Generated with make jobs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThe AWS OpenShift node compliance test is marked optional in both the content and ocp4e2e workflow configurations. ChangesCompliance workflow configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: taimurhafeez, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@Vincent056: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
![openshift-prow[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…PRs (openshift#82565) The lane has failed on effectively every run since 2026-07-17 across both ComplianceAsCode/content and ComplianceAsCode/ocp4e2e pull requests, for reasons unrelated to the changes under test: - when the cluster installs, the full-remediation node test times out waiting for MachineConfigPools (~590 remediations reboot every node; the master pool rolls serially and the 60-minute wait sits at the expected duration - e.g. content#14878, ocp4e2e#78 runs); - other runs die earlier in ipi-install-install (AWS installer infra). As a required job this blocks merges repo-wide while providing no usable signal. Keep always_run so the signal stays visible, but stop gating merges on it until it is stabilized. Reliability fixes for the underlying timeout are proposed in ComplianceAsCode/ocp4e2e#82 (raise the MCP wait to 120min, fix a MaxUnavailable bug that serialized worker reboots, add rollout diagnostics); intent is to make the job required again once the lane holds green. Generated with make jobs. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
Summary
Makes
ci/prow/e2e-aws-openshift-node-complianceoptional (non-merge-blocking) for both ComplianceAsCode/content and ComplianceAsCode/ocp4e2e pull requests. The job staysalways_run: trueso the signal remains visible on every PR.Why
The lane has failed on effectively every run since 2026-07-17 across both repos, for reasons unrelated to the changes under test:
Applied=589, Error=0, thenmaster (Updated: 1/3, Unavailable: 1)at 60m).ipi-install-install(AWS installer infra), e.g. content#14679 / content#14841 runs.As a required job this blocks merges repo-wide while providing no usable signal.
Path back to required
Reliability fixes for the underlying timeout are proposed in ComplianceAsCode/ocp4e2e#82 (raise the MCP wait to 120 min, fix a
MaxUnavailablepointer-comparison bug that kept worker reboots serialized, add rollout diagnostics on timeout). Once the lane holds green, this should be reverted to make the job required again.Generated with
make jobs; only the two ComplianceAsCode config files and their regenerated presubmits change (4 lines).Summary by CodeRabbit
ComplianceAsCode/contentandComplianceAsCode/ocp4e2epull requests.always_run: true) so results remain visible while infrastructure and remediation-test reliability issues are addressed.