SRVOCF-1003: update CI config for faas-console-plugin by pmeida · Pull Request #82896 · openshift/release

pmeida · 2026-08-04T14:32:17Z

Summary

Updates the CI configuration for openshift/faas-console-plugin to align with the companion repo PR openshift/faas-console-plugin#78, which introduces Dockerfile.buildroot and consolidates developer tooling under make targets.

Switch build_root from image_stream_tag to project_image using Dockerfile.buildroot
Simplify lint and unit tests to container format running make lint / make unit
Add e2e-aws multi-stage test: provisions an AWS cluster, installs Serverless and Pipelines operators via install-operators ref, runs make e2e with PLUGIN_PULL_SPEC injected
Use pipeline_skip_if_only_changed (correct field for steps-based tests) on e2e-aws
Consistent skip_if_only_changed pattern across all three tests, including .tekton/
test-bin is built once per CI run and shared by all tests in parallel, avoiding redundant yarn install and Playwright browser download at runtime. Note: runtime scripts (make e2e via hack/test-prow-e2e.sh) still run their own installs for correctness, but the warm node_modules cache makes them significantly faster.

Summary by CodeRabbit

Updates OpenShift CI for openshift/faas-console-plugin to use Dockerfile.buildroot through project_image.
Builds test-bin once and shares it across parallel tests.
Runs lint and unit tests with make lint and make unit.
Adds an AWS end-to-end test that installs required operators and runs make e2e with PLUGIN_PULL_SPEC.
Applies consistent change-based test skipping, including .tekton/ changes.

- Switch build_root to project_image using Dockerfile.builder - Simplify lint/unit tests to container format with make targets - Add e2e-aws multi-stage test with Serverless and Pipelines operators - Use pipeline_skip_if_only_changed for the steps-based e2e test - Align skip_if_only_changed patterns across all tests including .tekton/

openshift-ci-robot · 2026-08-04T14:32:21Z

@pmeida: This pull request references SRVOCF-1003 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Updates the CI configuration for openshift/faas-console-plugin to align with the companion repo PR openshift/faas-console-plugin#78, which introduces Dockerfile.builder and consolidates developer tooling under make targets.

Switch build_root from image_stream_tag to project_image using Dockerfile.builder

Simplify lint and unit tests to container format running make lint / make unit

Add e2e-aws multi-stage test: provisions an AWS cluster, installs Serverless and Pipelines operators via install-operators ref, runs make e2e with PLUGIN_PULL_SPEC injected

Use pipeline_skip_if_only_changed (correct field for steps-based tests) on e2e-aws

Consistent skip_if_only_changed pattern across all three tests, including .tekton/ per reviewer feedback

Companion PR

openshift/faas-console-plugin#78

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-04T14:32:47Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a7369fe-67c9-44d9-af29-56fb191fe834

📥 Commits

Reviewing files that changed from the base of the PR and between 95a5765 and b327f91.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/faas-console-plugin/openshift-faas-console-plugin-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml

Walkthrough

The CI configuration now uses Dockerfile.buildroot, updates resource requests, shares Yarn and Playwright setup, runs lint and unit checks through make, and adds an AWS end-to-end test with required operators.

Changes

FaaS console plugin CI

Layer / File(s)	Summary
Build image and shared validation `ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml`	The build uses `Dockerfile.buildroot`. Resource requests change to 1 CPU and 3 GiB memory. Shared setup installs Yarn dependencies and Playwright Chromium. Lint and unit checks run `make lint` and `make unit` from `test-bin` with expanded skip patterns.
AWS end-to-end workflow `ci-operator/config/openshift/faas-console-plugin/openshift-faas-console-plugin-master.yaml`	The AWS test installs Serverless and Pipelines operators, runs `make e2e` with the built plugin dependency, and sets extended grace-period, timeout, resource, and workflow settings.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CI as AWS CI workflow
  participant Cluster as AWS OpenShift cluster
  participant Operators as Cluster operators
  participant E2E as FaaS console plugin e2e
  CI->>Cluster: Start AWS test environment
  CI->>Operators: Install Serverless and Pipelines operators
  CI->>E2E: Run make e2e with built plugin dependency
  E2E->>Cluster: Execute end-to-end checks

Possibly related PRs

openshift/release#82169: Both changes configure AWS end-to-end CI workflows for OpenShift components.

Suggested reviewers: twogiants, dsimansk

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the CI configuration update for the faas-console-plugin and includes the relevant issue reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI YAML. Its test names are static (`lint`, `unit`, `e2e-aws`, `e2e`), with no Ginkgo declarations or dynamic values.
Test Structure And Quality	✅ Passed	The pull request changes only CI YAML; it adds no Ginkgo test code, so the stated Ginkgo quality check is not applicable.
Microshift Test Compatibility	✅ Passed	The pull request changes only CI YAML; it adds no Ginkgo tests or test code that references MicroShift-incompatible APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only two YAML CI configuration files; no Go files or added Ginkgo declarations are present, so the SNO test-compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only CI configuration and generated presubmit jobs; it adds no deployment, operator, controller, affinity, topology, node selector, replica, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only one CI YAML file; it contains no OTE process-level code or stdout writes to assess.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The branch changes only CI YAML and generated Prow jobs; it adds no Ginkgo test source or IPv4-specific code to assess.
No-Weak-Crypto	✅ Passed	The modified CI configuration file contains no weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time secret comparisons.
Container-Privileges	✅ Passed	The final CI YAML and added lines contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation:true, or root runtime setting.
No-Sensitive-Data-In-Logs	✅ Passed	The patch adds only dependency installation and test-container changes; the added lines contain no logging commands or passwords, tokens, keys, PII, hostnames, or customer data.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pmeida · 2026-08-04T14:38:37Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-e2e-aws
/pj-rehearse pull-ci-openshift-faas-console-plugin-master-lint
/pj-rehearse pull-ci-openshift-faas-console-plugin-master-unit
/pj-rehearse pull-ci-openshift-faas-console-plugin-master-images

openshift-merge-bot · 2026-08-04T14:39:04Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-08-04T14:42:29Z

@pmeida: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

openshift-merge-bot · 2026-08-04T14:42:33Z

@pmeida: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

openshift-merge-bot · 2026-08-04T14:42:36Z

@pmeida: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

pmeida · 2026-08-04T14:51:02Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-lint

pmeida · 2026-08-04T14:51:08Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-unit

pmeida · 2026-08-04T14:51:16Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-images

openshift-merge-bot · 2026-08-04T14:56:04Z

@pmeida: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

openshift-merge-bot · 2026-08-04T14:56:10Z

@pmeida: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

openshift-merge-bot · 2026-08-04T14:56:17Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-04T16:06:52Z

Waiting for openshift/faas-console-plugin#84 to be merged, to solve permission issue.

Pre-install yarn deps and Playwright browser once into test-bin, shared by lint, unit, and e2e in parallel rather than each reinstalling at runtime.

matejvasek · 2026-08-04T16:48:59Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-e2e-aws

openshift-merge-bot · 2026-08-04T16:49:02Z

@matejvasek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

matejvasek · 2026-08-04T16:49:07Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-images

openshift-merge-bot · 2026-08-04T16:52:02Z

@matejvasek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-04T23:06:11Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-e2e-aws

openshift-merge-bot · 2026-08-04T23:06:13Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-04T23:07:43Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-lint

openshift-merge-bot · 2026-08-04T23:07:47Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-04T23:08:34Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-unit

openshift-merge-bot · 2026-08-04T23:08:36Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-05T08:05:33Z

Added a temporary extra_refs pointing to openshift/faas-console-plugin#89.
This should allow us to test the e2e fixes immediately (dont have to wait for the component PR to be merged). It should also resolve faster if new failures come.
Should be removed at the end, and pj-rehearse should run one more time after the component PR is merged.

pmeida · 2026-08-05T08:06:34Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-e2e-aws

openshift-merge-bot · 2026-08-05T08:06:37Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

coderabbitai · 2026-08-05T08:07:54Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

dsimansk · 2026-08-05T09:09:57Z

@pmeida have you tried re-running make update? the config check should be passing.

update: I see it's the added ref

coderabbitai · 2026-08-05T09:41:07Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-08-05T09:44:19Z

[REHEARSALNOTIFIER]
@pmeida: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-faas-console-plugin-master-e2e-aws	openshift/faas-console-plugin	presubmit	Presubmit changed
pull-ci-openshift-faas-console-plugin-master-lint	openshift/faas-console-plugin	presubmit	Presubmit changed
pull-ci-openshift-faas-console-plugin-master-unit	openshift/faas-console-plugin	presubmit	Presubmit changed
pull-ci-openshift-faas-console-plugin-master-images	openshift/faas-console-plugin	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-merge-bot · 2026-08-05T10:18:26Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

pmeida · 2026-08-05T10:18:41Z

/pj-rehearse pull-ci-openshift-faas-console-plugin-master-e2e-aws

openshift-merge-bot · 2026-08-05T10:18:44Z

@pmeida: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-08-05T11:57:09Z

@pmeida: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

matejvasek · 2026-08-05T12:22:40Z

+    decorate: true
+    decoration_config:
+      sparse_checkout_files:
+      - Dockerfile


tbh I don't know how all this works, but should not be also Dockerfile.buildroot here? Maybe not I do not know.

It's probably all right.

matejvasek · 2026-08-05T12:27:39Z

/lgtm

/hold for @dsimansk

openshift-ci · 2026-08-05T12:28:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, pmeida

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/faas-console-plugin/OWNERS~~ [matejvasek]
~~ci-operator/jobs/openshift/faas-console-plugin/OWNERS~~ [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsimansk · 2026-08-05T12:36:35Z

/unhold

dsimansk · 2026-08-05T12:50:40Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-05T12:50:43Z

@dsimansk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

* SRVOCF-1003: update CI config for faas-console-plugin - Switch build_root to project_image using Dockerfile.builder - Simplify lint/unit tests to container format with make targets - Add e2e-aws multi-stage test with Serverless and Pipelines operators - Use pipeline_skip_if_only_changed for the steps-based e2e test - Align skip_if_only_changed patterns across all tests including .tekton/ * use test-bin for all tests via test_binary_build_commands Pre-install yarn deps and Playwright browser once into test-bin, shared by lint, unit, and e2e in parallel rather than each reinstalling at runtime.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 4, 2026

openshift-ci Bot requested review from dsimansk and twoGiants August 4, 2026 14:33

pmeida force-pushed the srvocf-1003-ci-config branch from cfd9792 to 6185720 Compare August 4, 2026 15:59

use test-bin for all tests via test_binary_build_commands

b327f91

Pre-install yarn deps and Playwright browser once into test-bin, shared by lint, unit, and e2e in parallel rather than each reinstalling at runtime.

pmeida force-pushed the srvocf-1003-ci-config branch from 6185720 to b327f91 Compare August 4, 2026 16:09

pmeida force-pushed the srvocf-1003-ci-config branch from 9987f00 to b327f91 Compare August 5, 2026 09:40

matejvasek reviewed Aug 5, 2026

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2026

openshift-ci Bot assigned matejvasek Aug 5, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 5, 2026

openshift-merge-bot Bot merged commit f34bc05 into openshift:main Aug 5, 2026
20 checks passed

Uh oh!

Conversation

pmeida commented Aug 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Aug 4, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Companion PR

Uh oh!

coderabbitai Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

matejvasek commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

matejvasek commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 4, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 4, 2026

Uh oh!

pmeida commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmeida commented Aug 5, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

dsimansk commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 5, 2026

pmeida commented Aug 4, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Aug 4, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Aug 4, 2026 •

edited

Loading

pmeida commented Aug 5, 2026 •

edited

Loading

dsimansk commented Aug 5, 2026 •

edited

Loading