Skip to content

AUTOSCALE-966: Update dockerfile paths of kedacore-http-add-on - #83167

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
linkvt:autoscale-966-http-add-on-ocp-containerfiles
Aug 10, 2026
Merged

AUTOSCALE-966: Update dockerfile paths of kedacore-http-add-on#83167
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
linkvt:autoscale-966-http-add-on-ocp-containerfiles

Conversation

@linkvt

@linkvt linkvt commented Aug 10, 2026

Copy link
Copy Markdown
Member

Update dockerfile_path references from operator/Dockerfile pattern to openshift/Containerfile.*.rhel.

Related PR: openshift/kedacore-http-add-on#7

Summary by CodeRabbit

  • Updates OpenShift CI image builds for kedacore-http-add-on.
  • Replaces component Dockerfile paths with the RHEL Containerfiles for the operator, interceptor, and scaler images.
  • References valid Jira issue AUTOSCALE-966; its target version still needs to be set to 5.0.0.

Update dockerfile_path references from operator/Dockerfile pattern to
openshift/Containerfile.*.rhel.

Signed-off-by: Vincent Link <vlink@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@linkvt: This pull request references AUTOSCALE-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update dockerfile_path references from operator/Dockerfile pattern to openshift/Containerfile.*.rhel.

Related PR: openshift/kedacore-http-add-on#7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from Fedosin and jkyros August 10, 2026 11:52
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e5568a33-b30e-4e14-8488-421c9abe9546

📥 Commits

Reviewing files that changed from the base of the PR and between 07f483d and e3ba287.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml

Walkthrough

The CI configuration updates the operator, interceptor, and scaler image builds to use their corresponding RHEL Containerfiles.

Changes

RHEL Containerfile references

Layer / File(s) Summary
Update image build paths
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml
The three image builds now reference openshift/Containerfile.operator.rhel, openshift/Containerfile.interceptor.rhel, and openshift/Containerfile.scaler.rhel.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the Dockerfile path updates for kedacore-http-add-on.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI YAML paths and sparse-checkout entries; no Ginkgo test declarations or test titles are added or modified.
Test Structure And Quality ✅ Passed The patch changes only three CI YAML files; it adds no Ginkgo tests or It blocks to review for structure, cleanup, timeouts, or assertion messages.
Microshift Test Compatibility ✅ Passed The pull request changes only CI YAML paths and generated job checkout lists; it adds no Ginkgo tests or MicroShift-sensitive API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI YAML dockerfile_path values; the HEAD diff adds no Ginkgo tests or test code that could make SNO-incompatible assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI image dockerfile_path values and CI job metadata; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only three CI YAML files for image build paths; it adds no OTE binary, Go, Ginkgo, or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds no Ginkgo e2e tests or network operations; it only updates Dockerfile paths in three CI YAML files.
No-Weak-Crypto ✅ Passed The PR changes only YAML path references and sparse-checkout entries; no added MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto implementation, or secret comparison code was found.
Container-Privileges ✅ Passed The three changed files only replace Dockerfile path strings. They add no privileged, host namespace, SYS_ADMIN, privilege-escalation, or root-user settings.
No-Sensitive-Data-In-Logs ✅ Passed The complete patch changes only Containerfile paths in build and sparse-checkout entries; it adds no logging statements or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@linkvt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kedacore-http-add-on-main-images openshift/kedacore-http-add-on presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@linkvt

linkvt commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/hold to pj-rehearse when related PRs have been merged

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2026
@joelsmith

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linkvt

linkvt commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@linkvt

linkvt commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2026
@linkvt

linkvt commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@linkvt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit e4677b0 into openshift:main Aug 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants