WIP: test disk encryption luks label

[mhanss]

Summary by CodeRabbit

• Adds a MachineConfig to the bare-metal SNO agent installation flow. The MachineConfig enables TPM2-backed LUKS encryption for the master root device and formats the mapped device as XFS.
• Removes the cluster-health test step from the baremetal-sno-agent-ipv4-static-connected-fips-f7 nightly job.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bebe82b0-1037-4baa-9300-e43df14f653e

📥 Commits

Reviewing files that changed from the base of the PR and between 9be95ee and e40da0b.

📒 Files selected for processing (2)

• ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.0__amd64-nightly.yaml
• ci-operator/step-registry/baremetal/lab/agent/install/baremetal-lab-agent-install-commands.sh

💤 Files with no reviewable changes (1)

• ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.0__amd64-nightly.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/step-registry/baremetal/lab/agent/install/baremetal-lab-agent-install-commands.sh

---

Walkthrough

The agent installation script now generates a TPM2-backed LUKS MachineConfig for the master root device. One nightly bare-metal SNO job no longer runs the cluster-health test.

Changes

Agent QE infrastructure

Layer / File(s)	Summary
Generate encrypted root MachineConfig ci-operator/step-registry/baremetal/lab/agent/install/baremetal-lab-agent-install-commands.sh	The script creates ${INSTALL_DIR}/openshift and writes a master-role MachineConfig. The configuration enables TPM2-backed LUKS encryption, wipes and reformats the root filesystem, and uses XFS.
Adjust nightly job tests ci-operator/config/openshift-eng/agent-qe-infra/openshift-eng-agent-qe-infra-release-5.0__amd64-nightly.yaml	The baremetal-sno-agent-ipv4-static-connected-fips-f7 job no longer runs cucushift-installer-check-cluster-health.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: rehearsals-ack

Suggested reviewers: bmanzari, pamoedom

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the main change as testing LUKS disk encryption, although it includes a work-in-progress qualifier.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI configuration and an install shell script; the diff adds no Ginkgo test-title declarations or dynamic test-name construction.
Test Structure And Quality	✅ Passed	The PR changes only a YAML job and a shell installer script; the patch contains no Ginkgo It blocks or test setup, cleanup, waits, or assertions to review.
Microshift Test Compatibility	✅ Passed	The PR changes only CI YAML and an install shell script; the diff adds no Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only a YAML job step and an installation shell script; no new Ginkgo It, Describe, Context, or When tests are present.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds a master-targeted MachineConfig for disk encryption and removes a health test; it adds no pod affinity, topology spread, toleration, node scheduling, replica, or PDB constraint.
Ote Binary Stdout Contract	✅ Passed	The patch changes only YAML and a shell installer; it adds file redirection and no OTE binary or process-level Go stdout/logging code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only CI YAML and a shell-generated MachineConfig; the diff adds no Ginkgo e2e tests or external connectivity code.
No-Weak-Crypto	✅ Passed	The added MachineConfig delegates LUKS to TPM2/Clevis and specifies AES-XTS; changed-file scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The added MachineConfig and job change contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security-context setting.
No-Sensitive-Data-In-Logs	✅ Passed	The added diff creates a static TPM/LUKS MachineConfig and removes a test; it adds no logging or secret fields, and existing installer output redacts passwords, X-Auth-Token, and UserData.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhanss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift-eng/agent-qe-infra/OWNERS [mhanss]
• ci-operator/step-registry/baremetal/lab/agent/OWNERS [mhanss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mhanss]

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-sno-agent-ipv4-static-connected-fips-f7

[openshift-merge-bot]

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[mhanss]

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-sno-agent-ipv4-static-connected-fips-f7

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@mhanss: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-eng-agent-qe-infra-extended-support-4.16-amd64-nightly-abi-bm-sno-agent-ipv4-static-connected-fips	openshift-eng/agent-qe-infra	presubmit	Registry content changed
pull-ci-openshift-eng-agent-qe-infra-extended-support-4.14-amd64-nightly-abi-bm-sno-agent-ipv4-static-connected-fips	openshift-eng/agent-qe-infra	presubmit	Registry content changed
pull-ci-openshift-eng-agent-qe-infra-extended-support-4.12-amd64-nightly-abi-bm-sno-agent-ipv4-static-connected-fips	openshift-eng/agent-qe-infra	presubmit	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-multi-nightly-baremetal-sno-agent-ipv4-static-disc-day2-arm-mixarch-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-stable-baremetal-pxe-sno-agent-ipv4-static-connected-fips-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-sno-agent-dualstack-dynamic-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ha-agent-dualstack-dynamic-fips-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-sno-agent-dualstack-dynamic-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-pxe-sno-agent-ipv4-static-connected-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-ha-agent-ipv4-static-disc-day2-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-sno-agent-ipv4-static-fips-day2-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-ha-agent-platform-none-ipv4-static-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.19-amd64-stable-baremetal-pxe-sno-agent-ipv4-static-connected-fips-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-5.0-multi-nightly-baremetal-compact-agent-ipv4-static-day2-amd-mixarch-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-arm64-nightly-baremetal-5-plus-0-agent-platform-none-ipv4-static-f28	N/A	periodic	Registry content changed
periodic-ci-rh-ecosystem-edge-recert-release-4.14-e2e-baremetal-pxe-sno-agent-ipv4-fips-recert	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-compact-agent-dualstack-dynamic-disc-fips-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.20-amd64-nightly-baremetal-compact-agent-ipv6-dynamic-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-4.21-upgrade-from-stable-4.20-metal-sno-agent-ipv4-static-connected-fips-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-amd64-nightly-baremetal-compact-agent-dualstack-dynamic-disc-fips-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-4.21-upgrade-from-stable-4.21-metal-sno-agent-ipv4-static-connected-fips-f60	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-4.21-upgrade-from-stable-4.20-metal-compact-agent-ipv4-static-connected-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.18-amd64-nightly-baremetal-sno-agent-ipv4-static-fips-day2-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.22-multi-nightly-baremetal-compact-agent-ipv4-static-day2-amd-mixarch-f7	N/A	periodic	Registry content changed
periodic-ci-openshift-eng-agent-qe-infra-release-4.21-amd64-nightly-baremetal-sno-agent-ipv4-static-connected-fips-f7	N/A	periodic	Registry content changed

A total of 210 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-merge-bot]

@mhanss: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[mhanss]

/pj-rehearse periodic-ci-openshift-eng-agent-qe-infra-release-5.0-amd64-nightly-baremetal-sno-agent-ipv4-static-connected-fips-f7

[openshift-merge-bot]

@mhanss: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@mhanss: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.