Skip to content

Fix TLS scanner for KEDA/Custom Metrics Autoscaler - #83185

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
joelsmith:main
Aug 10, 2026
Merged

Fix TLS scanner for KEDA/Custom Metrics Autoscaler#83185
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
joelsmith:main

Conversation

@joelsmith

@joelsmith joelsmith commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

It appears that the E2E test currently runs in the keda NS. Let's have the scanner check both so that we can move the test from keda to openshift-keda later without breaking the TLS scanner test.

This is a follow-up to #82248 which was the first PQC test our team added, so we didn't know what the test was supposed to look like. It looked like this: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/82248/rehearse-82248-pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn/2080177699275411456/artifacts/cma-e2e-aws-ovn/tls-scanner-run/build-log.txt and it needs to look more like https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/83133/rehearse-83133-pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws/2085841162609889280/artifacts/e2e-aws/tls-scanner-run/build-log.txt

Summary by CodeRabbit

The AWS OVN CMA end-to-end TLS scanner test now checks both the keda and openshift-keda namespaces. This supports moving the test between namespaces without breaking TLS scan coverage.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The AWS OVN end-to-end test configuration now scans both keda and openshift-keda namespaces.

Changes

CMA test configuration

Layer / File(s) Summary
Namespace scan configuration
ci-operator/config/openshift/custom-metrics-autoscaler-operator/openshift-custom-metrics-autoscaler-operator-main.yaml
The SCAN_NAMESPACE setting now includes keda and openshift-keda.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: fedosin

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only SCAN_NAMESPACE from one static namespace to two static namespaces; it adds no Ginkgo It, Describe, Context, or When test title.
Test Structure And Quality ✅ Passed The PR changes only one YAML environment value; it adds no Ginkgo It blocks or cluster operations, and the comma-separated namespace format matches existing CI configurations.
Microshift Test Compatibility ✅ Passed The PR only changes SCAN_NAMESPACE from openshift-keda to keda,openshift-keda; it adds no Ginkgo e2e test or new API/resource reference.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only SCAN_NAMESPACE from one namespace to two in CI YAML; it adds no Ginkgo test or multi-node/HA assumption.
Topology-Aware Scheduling Compatibility ✅ Passed The only change is the CI environment variable SCAN_NAMESPACE; it adds no deployment, controller, replica, affinity, topology spread, node selection, taint, or PDB scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only SCAN_NAMESPACE in a CI YAML file; it adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only SCAN_NAMESPACE in CI YAML; it adds no Ginkgo e2e test, IPv4 assumption, or external connectivity requirement.
No-Weak-Crypto ✅ Passed The commit changes only SCAN_NAMESPACE from one namespace to two; no weak algorithms, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed The PR changes only SCAN_NAMESPACE from openshift-keda to keda,openshift-keda; the patch contains no privilege-related fields or capabilities.
No-Sensitive-Data-In-Logs ✅ Passed The only change sets SCAN_NAMESPACE to the public namespace names keda,openshift-keda; it adds no passwords, tokens, keys, PII, hostnames, or customer data to logs.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the TLS scanner fix for KEDA and Custom Metrics Autoscaler, which matches the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@joelsmith: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn openshift/custom-metrics-autoscaler-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
openshift-ci Bot requested review from Fedosin and maxcao13 August 10, 2026 15:31
@joelsmith

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@joelsmith

joelsmith commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Looks like a flake in the E2E
/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shyadav10

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@shyadav10

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, shyadav10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelsmith

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 93cf1e9 into openshift:main Aug 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants