Skip to content

adding updates for prow in 5.1 - #83187

Open
kurwang wants to merge 2 commits into
openshift:mainfrom
kurwang:ACM-39282
Open

adding updates for prow in 5.1#83187
kurwang wants to merge 2 commits into
openshift:mainfrom
kurwang:ACM-39282

Conversation

@kurwang

@kurwang kurwang commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

multicluster-role-assignment

1. New CI operator config for release-5.1

  • Created stolostron-multicluster-role-assignment-release-5.1.yaml — exact copy of the 5.0 config with promotion.name changed to "5.1" and disabled: true set (bootstrap posture until main is retargeted to a future release)

2. Updated prowconfig branch protection

  • main branch: Konflux checks updated from acm-50acm-51 (since main now targets the 5.1 development cycle)
  • Added release-5.1 branch protection requiring acm-51 Konflux checks (enterprise-contract and on-pull-request)

3. Generated Prow jobs

  • New release-5.1-presubmits.yaml and release-5.1-postsubmits.yaml auto-generated by make update

mtv-integrations

1. New CI operator config for release-5.1

  • Created stolostron-mtv-integrations-release-5.1.yaml — copy of the 5.0 config with promotion.name changed to "5.1" and disabled: true added

2. Removed fast-forward from main

  • Removed the fast-forward postsubmit job from main.yaml that was forwarding mainrelease-5.0 (per the Jira ticket warning: "If fast-forwarding is configured in 5.0, this needs to be disabled")

3. Updated prowconfig branch protection

  • main branch: Added acm-51 Konflux checks (previously had none, only protect: true)
  • Added release-5.1 branch protection requiring acm-51 Konflux checks

4. Generated Prow jobs

  • New release-5.1-presubmits.yaml and release-5.1-postsubmits.yaml auto-generated
  • main-postsubmits.yaml regenerated (fast-forward job removed)

Summary by CodeRabbit

  • Added release-5.1 CI configurations for mtv-integrations and multicluster-role-assignment.
  • Configured builds, tests, image publishing, mirroring, and disabled release-5.1 promotion where required.
  • Enabled multicluster-role-assignment release-5.0 promotion.
  • Updated branch protection with required ACM 5.1 Konflux checks.
  • Removed the mtv-integrations main fast-forward postsubmit to release-5.0.
  • Regenerated release-5.1 Prow presubmit and postsubmit jobs.

Signed-off-by: kurwang <kurwang@redhat.com>
@kurwang

kurwang commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/hold wait until branch day

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2026
Remove disabled: true from release-5.0 promotion so the release
branch actively produces its own 5.0 images, aligning with
mtv-integrations and other components that have already enabled it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0407b773-518a-4499-9a57-a12ff2603241

📥 Commits

Reviewing files that changed from the base of the PR and between b136251 and 6c87edc.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/stolostron/mtv-integrations/stolostron-mtv-integrations-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/mtv-integrations/stolostron-mtv-integrations-release-5.1-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/mtv-integrations/stolostron-mtv-integrations-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/multicluster-role-assignment/stolostron-multicluster-role-assignment-release-5.1-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/multicluster-role-assignment/stolostron-multicluster-role-assignment-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (6)
  • ci-operator/config/stolostron/mtv-integrations/stolostron-mtv-integrations-main.yaml
  • ci-operator/config/stolostron/mtv-integrations/stolostron-mtv-integrations-release-5.1.yaml
  • ci-operator/config/stolostron/multicluster-role-assignment/stolostron-multicluster-role-assignment-release-5.0.yaml
  • ci-operator/config/stolostron/multicluster-role-assignment/stolostron-multicluster-role-assignment-release-5.1.yaml
  • core-services/prow/02_config/stolostron/mtv-integrations/_prowconfig.yaml
  • core-services/prow/02_config/stolostron/multicluster-role-assignment/_prowconfig.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/stolostron/mtv-integrations/stolostron-mtv-integrations-main.yaml

Walkthrough

The PR adds release 5.1 CI configurations and protected-branch checks for mtv-integrations and multicluster-role-assignment. It also enables 5.0 promotion for the latter and removes an obsolete fast-forward workflow.

Changes

Release CI configuration

Layer / File(s) Summary
MTV Integrations release pipeline
ci-operator/config/stolostron/mtv-integrations/*
Adds the release 5.1 build, test, Sonar, image publication, promotion, resource, and metadata settings. Removes the obsolete main-branch fast-forward workflow.
MTV Integrations branch checks
core-services/prow/02_config/stolostron/mtv-integrations/_prowconfig.yaml
Requires ACM 5.1 Konflux checks on main and release-5.1.
Multicluster Role Assignment release pipeline
ci-operator/config/stolostron/multicluster-role-assignment/*
Enables 5.0 promotion and adds release 5.1 build, test, Sonar, mirroring, publishing, resource, and metadata settings.
Multicluster Role Assignment branch checks
core-services/prow/02_config/stolostron/multicluster-role-assignment/_prowconfig.yaml
Updates main to ACM 5.1 checks and adds protected release-5.1 checks.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Prow configuration updates for the 5.1 development cycle.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI/Prow YAML; repository searches found no Ginkgo declarations or dynamic test titles in 41 Go files or generated jobs.
Test Structure And Quality ✅ Passed The full PR diff changes only 11 YAML CI/Prow configuration files and adds no Ginkgo test code, assertions, waits, setup, or cleanup to review.
Microshift Test Compatibility ✅ Passed The PR range changes only YAML CI and Prow configuration; no Go files or new Ginkgo declarations (It, Describe, Context, or When) were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML CI and Prow configuration files; it adds no Ginkgo e2e tests or multi-node test assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI-operator and Prow configuration files; no deployment manifests, operator code, controllers, or topology scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed The PR diff contains only 11 YAML configuration/job files and no Go or OTE binary source, so it introduces no process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only 11 YAML CI/Prow files; it adds no Ginkgo declarations or Go/e2e tests, and added lines contain no flagged IPv4 literals or external URLs.
No-Weak-Crypto ✅ Passed The PR changes only CI/Prow YAML; a boundary-aware scan of all 1,151 added lines found no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto operation, or secret comparison.
Container-Privileges ✅ Passed Changed CI and Prow YAML contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root-user declarations.
No-Sensitive-Data-In-Logs ✅ Passed Added logs print only a local KUBEBUILDER_ASSETS path and Go package list; no passwords, tokens, PII, hostnames, or customer data are logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from fxiang1 and jnpacker August 10, 2026 15:40
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kurwang
Once this PR has been reviewed and has the lgtm label, please assign yiraechristinekim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kurwang: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kurwang: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-mtv-integrations-release-5.1-images stolostron/mtv-integrations presubmit Presubmit changed
pull-ci-stolostron-mtv-integrations-release-5.1-sonar stolostron/mtv-integrations presubmit Presubmit changed
pull-ci-stolostron-mtv-integrations-release-5.1-unit-tests stolostron/mtv-integrations presubmit Presubmit changed
pull-ci-stolostron-multicluster-role-assignment-release-5.1-images stolostron/multicluster-role-assignment presubmit Presubmit changed
pull-ci-stolostron-multicluster-role-assignment-release-5.1-pr-image-mirror stolostron/multicluster-role-assignment presubmit Presubmit changed
pull-ci-stolostron-multicluster-role-assignment-release-5.1-sonar-pre-submit stolostron/multicluster-role-assignment presubmit Presubmit changed
pull-ci-stolostron-multicluster-role-assignment-release-5.1-unit-tests stolostron/multicluster-role-assignment presubmit Presubmit changed
pull-ci-stolostron-multicluster-role-assignment-release-5.0-images stolostron/multicluster-role-assignment presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-role-assignment-release-5.0-pr-image-mirror stolostron/multicluster-role-assignment presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-role-assignment-release-5.0-sonar-pre-submit stolostron/multicluster-role-assignment presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-role-assignment-release-5.0-unit-tests stolostron/multicluster-role-assignment presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@kurwang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant