Expand and require Gateway API conformance pipeline trigger for CIO - #83189
Expand and require Gateway API conformance pipeline trigger for CIO#83189gcs278 wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
WalkthroughThe AWS Gateway API conformance trigger now matches broader Gateway controller changes, Istio Sail paths, and Gateway API vendor paths. The pipeline is no longer optional. ChangesGateway API conformance
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@gcs278: |
4f8b6eb to
8c46680
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
8c46680 to
5c67e2d
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@gcs278: |
Expand the pipeline_run_if_changed regex for e2e-aws-gatewayapi-conformance to cover all gateway-related controllers, vendor dependencies, and manifests: - pkg/operator/controller/gateway.*/ (was only gatewayapi/) - vendor/github.com/istio-ecosystem/sail-operator/ - vendor/sigs.k8s.io/gateway-api/ - manifests/ Also remove optional: true so the conformance test blocks merge when triggered. This matches the pattern used by openshift/api and cluster-authentication-operator for pipeline-triggered required tests.
5c67e2d to
471b435
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/assign @rhamini3 |
|
@gcs278 this looks good, thanks for updating the regex command |
|
/pj-rehearse |
|
@rhamini3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, rhamini3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Expand the
pipeline_run_if_changedregex fore2e-aws-gatewayapi-conformanceand make the test required (removeoptional: true) when triggered.Changes
pkg/operator/controller/gatewayapi/topkg/operator/controller/gateway.*/to cover all gateway-related controllers (gatewayclass, gateway-service-dns, gateway-labeler, etc.)vendor/github.com/istio-ecosystem/sail-operator/andvendor/sigs.k8s.io/gateway-api/to catch sail-operator and Gateway API version bumpsmanifests/to catch RBAC, PrometheusRule, and deployment changes that could affect Gateway API behavioroptional: trueso the conformance test blocks merge when the pipeline controller triggers it on relevant file changes. PRs that don't touch these paths are unaffected.This follows the same pattern used by
openshift/apiandcluster-authentication-operatorfor pipeline-triggered required tests.Summary by CodeRabbit
The
cluster-ingress-operatorCI configuration now runse2e-aws-gatewayapi-conformancefor changes in gateway-related controllers, Istio Sail paths, and Gateway API vendor paths. The conformance test is required when these changes trigger the job.