Skip to content

Expand and require Gateway API conformance pipeline trigger for CIO - #83189

Open
gcs278 wants to merge 1 commit into
openshift:mainfrom
gcs278:expand-conformance-pipeline-trigger
Open

Expand and require Gateway API conformance pipeline trigger for CIO#83189
gcs278 wants to merge 1 commit into
openshift:mainfrom
gcs278:expand-conformance-pipeline-trigger

Conversation

@gcs278

@gcs278 gcs278 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Expand the pipeline_run_if_changed regex for e2e-aws-gatewayapi-conformance and make the test required (remove optional: true) when triggered.

Changes

  • Broader controller coverage: Expand regex from pkg/operator/controller/gatewayapi/ to pkg/operator/controller/gateway.*/ to cover all gateway-related controllers (gatewayclass, gateway-service-dns, gateway-labeler, etc.)
  • Vendor dependency coverage: Add vendor/github.com/istio-ecosystem/sail-operator/ and vendor/sigs.k8s.io/gateway-api/ to catch sail-operator and Gateway API version bumps
  • Manifest coverage: Add manifests/ to catch RBAC, PrometheusRule, and deployment changes that could affect Gateway API behavior
  • Required when triggered: Remove optional: true so the conformance test blocks merge when the pipeline controller triggers it on relevant file changes. PRs that don't touch these paths are unaffected.

This follows the same pattern used by openshift/api and cluster-authentication-operator for pipeline-triggered required tests.

Summary by CodeRabbit

The cluster-ingress-operator CI configuration now runs e2e-aws-gatewayapi-conformance for changes in gateway-related controllers, Istio Sail paths, and Gateway API vendor paths. The conformance test is required when these changes trigger the job.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The AWS Gateway API conformance trigger now matches broader Gateway controller changes, Istio Sail paths, and Gateway API vendor paths. The pipeline is no longer optional.

Changes

Gateway API conformance

Layer / File(s) Summary
Update conformance trigger
ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml
The trigger matches pkg/operator/controller/gateway.*/.*, Istio Sail paths, and Gateway API vendor paths. The pipeline no longer uses optional: true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aswinsuryan, grzpiotrowski

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI YAML and generated Prow metadata; the changed files contain no Ginkgo title declarations or dynamic test names.
Test Structure And Quality ✅ Passed The pull request changes only CI YAML configuration files and adds no Ginkgo test code; the test-structure quality check is not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only CI YAML and adds no Ginkgo e2e tests, so MicroShift API compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only two CI YAML files; it adds no Ginkgo e2e tests or other test code that could introduce SNO multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI trigger configuration and a generated presubmit; it adds no deployment, controller, replica, affinity, topology, node-selector, toleration, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only two YAML CI files and adds no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI YAML and generated presubmit configuration; it adds no Ginkgo e2e tests or runtime networking, IPv4, or external-connectivity behavior.
No-Weak-Crypto ✅ Passed The patch changes only CI YAML trigger patterns and required-test settings; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation.
Container-Privileges ✅ Passed The PR changes only a pipeline regex and removes optional: true; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only YAML trigger metadata: a path regex and removal of optional status; it adds no logging, command, or sensitive data output.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: expanding the Gateway API conformance trigger and making it required for CIO.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gcs278: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@gcs278
gcs278 force-pushed the expand-conformance-pipeline-trigger branch from 4f8b6eb to 8c46680 Compare August 10, 2026 15:52
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@gcs278
gcs278 force-pushed the expand-conformance-pipeline-trigger branch from 8c46680 to 5c67e2d Compare August 10, 2026 16:16
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@gcs278 gcs278 changed the title Expand CIO Gateway API conformance pipeline trigger to all gateway controllers Expand and require Gateway API conformance pipeline trigger for CIO Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gcs278: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@gcs278
gcs278 marked this pull request as ready for review August 10, 2026 16:52
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
Expand the pipeline_run_if_changed regex for e2e-aws-gatewayapi-conformance
to cover all gateway-related controllers, vendor dependencies, and manifests:
- pkg/operator/controller/gateway.*/ (was only gatewayapi/)
- vendor/github.com/istio-ecosystem/sail-operator/
- vendor/sigs.k8s.io/gateway-api/
- manifests/

Also remove optional: true so the conformance test blocks merge when
triggered. This matches the pattern used by openshift/api and
cluster-authentication-operator for pipeline-triggered required tests.
@gcs278
gcs278 force-pushed the expand-conformance-pipeline-trigger branch from 5c67e2d to 471b435 Compare August 10, 2026 17:02
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gcs278: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi-conformance openshift/cluster-ingress-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gcs278

gcs278 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/assign @rhamini3

@rhamini3

Copy link
Copy Markdown
Contributor

@gcs278 this looks good, thanks for updating the regex command
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@rhamini3

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rhamini3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, rhamini3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants