OCPBUGS-105356: For ABI 4.22 iso-no-registry tests use CustomNoUpgrade - #83193
OCPBUGS-105356: For ABI 4.22 iso-no-registry tests use CustomNoUpgrade#83193bfournie wants to merge 1 commit into
Conversation
In 4.22, using TechPreviewNoUpgrade pulls in capi which results in installation failures (see bug). Since its not feasible to backport the capi changes to 4.22 we will use CustomNoUpgrade+NoRegistryClusterInstall to do the installation and avoid pulling in capi.
|
@bfournie: This pull request references Jira Issue OCPBUGS-105356, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughFour ISO-no-registry agent conformance jobs now use ChangesISO no-registry jobs
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse |
|
@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/jira refresh |
|
@bfournie: This pull request references Jira Issue OCPBUGS-105356, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
In 4.22, using TechPreviewNoUpgrade pulls in capi which results in installation failures (see bug). Since its not feasible to backport the capi changes to 4.22 we will use CustomNoUpgrade+NoRegistryClusterInstall to do the installation and avoid pulling in capi.
Summary by CodeRabbit
TechPreviewNoUpgradewithCustomNoUpgradeand enablesNoRegistryClusterInstall=true.