Skip to content

OCPBUGS-105356: For ABI 4.22 iso-no-registry tests use CustomNoUpgrade - #83193

Open
bfournie wants to merge 1 commit into
openshift:mainfrom
bfournie:agent-iso-no-registry-custom-featureset-4.22
Open

OCPBUGS-105356: For ABI 4.22 iso-no-registry tests use CustomNoUpgrade#83193
bfournie wants to merge 1 commit into
openshift:mainfrom
bfournie:agent-iso-no-registry-custom-featureset-4.22

Conversation

@bfournie

@bfournie bfournie commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

In 4.22, using TechPreviewNoUpgrade pulls in capi which results in installation failures (see bug). Since its not feasible to backport the capi changes to 4.22 we will use CustomNoUpgrade+NoRegistryClusterInstall to do the installation and avoid pulling in capi.

Summary by CodeRabbit

  • Updates four ABI 4.22 ISO no-registry agent conformance jobs in OpenShift CI.
  • Replaces TechPreviewNoUpgrade with CustomNoUpgrade and enables NoRegistryClusterInstall=true.
  • Avoids pulling in CAPI, which currently causes 4.22 installation failures.

In 4.22, using TechPreviewNoUpgrade pulls in capi which results in
installation failures (see bug). Since its not feasible to backport
the capi changes to 4.22 we will use CustomNoUpgrade+NoRegistryClusterInstall
to do the installation and avoid pulling in capi.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-105356, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In 4.22, using TechPreviewNoUpgrade pulls in capi which results in installation failures (see bug). Since its not feasible to backport the capi changes to 4.22 we will use CustomNoUpgrade+NoRegistryClusterInstall to do the installation and avoid pulling in capi.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f9609da8-2a88-4f50-a6ed-98ef01efe6cb

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2a11c and daa7963.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

Walkthrough

Four ISO-no-registry agent conformance jobs now use CustomNoUpgrade and enable NoRegistryClusterInstall=true instead of using TechPreviewNoUpgrade.

Changes

ISO no-registry jobs

Layer / File(s) Summary
Configure job feature gates
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
The compact IPv4, HA dual-stack, HA five-control-plane dual-stack, and SNO IPv4 jobs now use CustomNoUpgrade with NoRegistryClusterInstall=true.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: dustman9000, mkowalski, kasturinarra

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the ABI 4.22 iso-no-registry test change to use CustomNoUpgrade, which matches the main pull request change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only four YAML environment blocks: static FEATURE_SET and FEATURE_GATES values. It adds no Ginkgo title calls or dynamic test-name content.
Test Structure And Quality ✅ Passed The commit changes only one YAML CI configuration file and adds no Ginkgo test code, It blocks, resource setup, waits, or assertions; the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The commit changes only one YAML CI configuration file; it adds no Ginkgo tests or test declarations, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only one CI YAML file and adds no Ginkgo tests or test source, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes only CI test environment variables in one YAML file; it adds no deployment, operator, controller, or topology-related scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only one YAML configuration file; its four edits set feature environment variables and add no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only one YAML job configuration; it adds no Ginkgo tests, IPv4 parsing, hardcoded addresses, or external connectivity.
No-Weak-Crypto ✅ Passed The commit changes only one YAML file; its eight added lines contain feature settings, and the boundary-aware scan found no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto comparison usage.
Container-Privileges ✅ Passed The PR adds only FEATURE_SET and FEATURE_GATES values to four test jobs; the patch introduces no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit only changes four YAML environment blocks to feature-set and feature-gate identifiers; it adds no logging code or passwords, tokens, API keys, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from dgoodwin and neisw August 10, 2026 16:18
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bfournie: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-sno-ipv4-iso-no-registry N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha-dualstack-iso-no-registry N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bfournie

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-105356, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants