Netobserv baremetal testing

[Amoghrd]

Summary by CodeRabbit

NetObserv Operator bare-metal test jobs for OpenShift 4.18, 4.20, and 4.22 now have a six-hour timeout. Each job waits for cluster preparation to complete before starting the main test chain.

[Amoghrd]

/hold

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: eb36aa83-2234-492a-97b2-11b7b3b400ce

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2a11c and b9c549c.

📒 Files selected for processing (3)

• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.18.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.20.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.22.yaml

---

Walkthrough

The PR updates six bare-metal NetObserv test jobs for nightly 4.18, 4.20, and 4.22 configurations. Each job now waits after cluster preparation and uses a six-hour TIMEOUT.

Changes

NetObserv bare-metal job configuration

Layer / File(s)	Summary
Bare-metal timeout and preparation sequencing ci-operator/config/openshift/network-observability-operator/*nightly-4.18.yaml, *nightly-4.20.yaml, *nightly-4.22.yaml	Six bare-metal test jobs now set TIMEOUT to six hours and add a wait step after cluster preparation.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• openshift/release#82411: Modifies the same NetObserv CI job files with similar timeout and wait changes.
• openshift/release#83100: Updates Prow test configurations with extended timeouts and sequencing.

Suggested reviewers: memodi, oliver-smakal

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the pull request's main change to NetObserv bare-metal testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only three YAML configs by adding TIMEOUT and the static wait reference; it adds no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality	✅ Passed	The commit changes only three CI YAML files; it adds TIMEOUT and wait steps, with no Ginkgo It blocks, setup, cleanup, or assertions to review.
Microshift Test Compatibility	✅ Passed	The commit only modifies three ci-operator YAML files; it adds no Ginkgo tests or test code that can reference MicroShift-incompatible APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The patch changes only three CI YAML files by adding TIMEOUT and wait references; it adds no Ginkgo tests or multi-node test logic.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only three ci-operator test YAML files, adding TIMEOUT and ref: wait; no deployment, controller, or topology scheduling constraints were modified.
Ote Binary Stdout Contract	✅ Passed	The patch changes only three YAML job configurations and adds TIMEOUT and wait references; it contains no process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only three CI YAML files, adding TIMEOUT and wait references; it adds no Ginkgo test code or IPv4/external connectivity behavior.
No-Weak-Crypto	✅ Passed	The patch adds only TIMEOUT values and wait references in three YAML files; no weak algorithms, crypto code, or secret comparisons appear in added lines.
Container-Privileges	✅ Passed	The PR adds only TIMEOUT and wait entries. It adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The patch adds only TIMEOUT values and wait references; it adds no logging, secrets, tokens, credentials, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/network-observability-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

@Amoghrd: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[openshift-ci]

@Amoghrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Amoghrd]

/pj-rehearse list

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Amoghrd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-ipv4-f60-virt	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-ipv4-f60-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.