Skip to content

functions-operator: Require unit, lint, and e2e checks - #83198

Closed
gauron99 wants to merge 1 commit into
openshift:mainfrom
gauron99:push-xvxrmmvxqsmv
Closed

functions-operator: Require unit, lint, and e2e checks#83198
gauron99 wants to merge 1 commit into
openshift:mainfrom
gauron99:push-xvxrmmvxqsmv

Conversation

@gauron99

@gauron99 gauron99 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add branch protection for openshift/functions-operator main branch
  • Require ci/prow/unit, ci/prow/lint, and ci/prow/e2e-install-aws to pass before merge
  • Follows the same pattern as addon-operator, certman-operator, and other repos

cc @maschmid

Summary by CodeRabbit

  • Adds branch protection for the main branch in openshift/functions-operator.
  • Requires ci/prow/unit, ci/prow/lint, and ci/prow/e2e-install-aws checks to pass before merges.

@gauron99 gauron99 changed the title Require unit, lint, and e2e checks for functions-operator functions-operator: Require unit, lint, and e2e checks Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The Prow configuration adds protection for the main branch of openshift/functions-operator. The protection requires unit tests, linting, and AWS installation end-to-end tests.

Changes

Functions Operator Branch Protection

Layer / File(s) Summary
Configure required main branch checks
core-services/prow/02_config/openshift/functions-operator/_prowconfig.yaml
The main branch now requires ci/prow/unit, ci/prow/lint, and ci/prow/e2e-install-aws status checks.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a YAML branch-protection file; it adds static status-check names and contains no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The PR changes only _prowconfig.yaml to add branch protection; it adds no Ginkgo tests or cluster operations requiring this quality review.
Microshift Test Compatibility ✅ Passed The PR changes only Prow YAML branch protection; no Ginkgo e2e tests or test files were added, so MicroShift compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only _prowconfig.yaml to add branch protection; it adds no Ginkgo e2e tests, so no SNO compatibility issue applies.
Topology-Aware Scheduling Compatibility ✅ Passed The only change is Prow branch-protection YAML; it adds required status checks and introduces no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only a Prow YAML file; it adds no OTE binary, suite setup, initializer, logging, or stdout write to assess.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only one Prow YAML file to add branch-protection status checks; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The commit adds only 13 YAML branch-protection lines; the added content contains no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison usage.
Container-Privileges ✅ Passed The PR changes only Prow branch-protection configuration; it contains no container or Kubernetes privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch changes only Prow branch-protection YAML and adds no logging statements or sensitive values such as tokens, passwords, PII, or hostnames.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the branch protection change and names the required unit, lint, and end-to-end checks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gauron99

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gauron99: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
openshift-ci Bot requested review from maschmid and perdasilva August 10, 2026 17:04
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gauron99: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gauron99: no rehearsable tests are affected by this change

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@gauron99: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/config 808fb5d link true /test config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gauron99

Copy link
Copy Markdown
Contributor Author

Not needed -- Tide already requires always_run jobs to pass. The skip_if_only_changed on our jobs conflicts with required_status_checks (jobs can't be both skippable and required).

@gauron99 gauron99 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant