Skip to content

Add Prow & Unit Testing to DRA Driver SR-IOV - #83206

Open
wizhaoredhat wants to merge 1 commit into
openshift:mainfrom
wizhaoredhat:add_dra_driver_sriov_prow
Open

Add Prow & Unit Testing to DRA Driver SR-IOV#83206
wizhaoredhat wants to merge 1 commit into
openshift:mainfrom
wizhaoredhat:add_dra_driver_sriov_prow

Conversation

@wizhaoredhat

@wizhaoredhat wizhaoredhat commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Adds OpenShift CI support for the openshift/dra-driver-sriov repository.
  • Builds and promotes images with Dockerfile.ocp and integrates releases.
  • Adds a make test unit test job with resource settings.
  • Enables Prow approval and LGTM workflows.
  • Configures Tide to merge only pull requests with approved, lgtm, and verified labels that have no blocking labels.
  • Defines repository reviewers and approvers.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The pull request onboards dra-driver-sriov with OpenShift CI, image promotion, repository ownership, Prow approval settings, and Tide merge requirements.

Changes

Repository onboarding

Layer / File(s) Summary
OpenShift CI build and validation
ci-operator/config/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main.yaml
Defines the repository build, Dockerfile.ocp image, resource requests, make test unit test, and main branch metadata.
Image promotion and release integration
ci-operator/config/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main.yaml
Adds promotion targets and 5.0 release integration settings.
Ownership and merge governance
ci-operator/config/openshift/dra-driver-sriov/OWNERS, core-services/prow/02_config/openshift/dra-driver-sriov/_pluginconfig.yaml, core-services/prow/02_config/openshift/dra-driver-sriov/_prowconfig.yaml
Defines reviewers and approvers. Enables approval and LGTM handling. Tide requires approved, lgtm, and verified labels and excludes pull requests with specified blocking labels.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: rehearsals-ack

Suggested reviewers: hector-vido, bear-redhat

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding Prow configuration and unit testing for the DRA Driver SR-IOV component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML and OWNERS files; no Ginkgo declarations or dynamic test-title construction exists. The configured unit test identifier is the static name unit.
Test Structure And Quality ✅ Passed The PR adds only Prow/CI YAML and OWNERS files; no Ginkgo test code, It blocks, or cluster operations are present, so this check is not applicable.
Microshift Test Compatibility ✅ Passed The diff adds only CI, Prow, OWNERS, and a make test unit-test target; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit adds only YAML and OWNERS files; its sole test entry runs make test, with no new Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit adds only CI/Prow YAML and OWNERS files; no deployment, operator, or controller scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed All six changed files are CI/Prow YAML or OWNERS metadata; no Go entrypoint, suite setup, or stdout-writing code changed, so the OTE contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds only YAML and OWNERS configuration; it adds no Ginkgo e2e tests or test networking code, so this check is not applicable.
No-Weak-Crypto ✅ Passed The six added files contain only CI/Prow YAML and OWNERS data; scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed All six added files were inspected; no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation:true, or explicit root execution settings are present.
No-Sensitive-Data-In-Logs ✅ Passed Changed files add no logging code or literal secrets/PII; credential references are standard secret file paths and mounts in the generated Prow job.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@core-services/prow/02_config/openshift/dra-driver-sriov/_prowconfig.yaml`:
- Around line 3-5: Update Tide’s query labels list in the Prow configuration to
include the verified label alongside approved and lgtm, ensuring only verified
pull requests satisfy the merge query.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 64b3279f-179f-4e4e-b470-9cd03b8d1c13

📥 Commits

Reviewing files that changed from the base of the PR and between 47597c3 and 7dedb32.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/openshift/dra-driver-sriov/openshift-dra-driver-sriov-main.yaml
  • core-services/prow/02_config/openshift/dra-driver-sriov/_pluginconfig.yaml
  • core-services/prow/02_config/openshift/dra-driver-sriov/_prowconfig.yaml

@wizhaoredhat
wizhaoredhat force-pushed the add_dra_driver_sriov_prow branch from 7dedb32 to 33d2c9e Compare August 10, 2026 19:20
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@wizhaoredhat
wizhaoredhat force-pushed the add_dra_driver_sriov_prow branch from 33d2c9e to 821f5a9 Compare August 10, 2026 19:32
@wizhaoredhat

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@wizhaoredhat

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@wizhaoredhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@wizhaoredhat
wizhaoredhat force-pushed the add_dra_driver_sriov_prow branch from 821f5a9 to 0274645 Compare August 10, 2026 20:43
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@wizhaoredhat
wizhaoredhat force-pushed the add_dra_driver_sriov_prow branch from 0274645 to 146bdf0 Compare August 10, 2026 20:49
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Signed-off-by: William Zhao <wizhao@redhat.com>
@wizhaoredhat
wizhaoredhat force-pushed the add_dra_driver_sriov_prow branch from 146bdf0 to 0c6f9a8 Compare August 10, 2026 21:08
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wizhaoredhat
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@wizhaoredhat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-dra-driver-sriov-main-images openshift/dra-driver-sriov presubmit Presubmit changed
pull-ci-openshift-dra-driver-sriov-main-unit openshift/dra-driver-sriov presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@wizhaoredhat

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@wizhaoredhat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@wizhaoredhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/dra-driver-sriov/main/unit 0c6f9a8 link unknown /pj-rehearse pull-ci-openshift-dra-driver-sriov-main-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant