[kustomize_deploy] Fix MetalLB CR creation race with webhook readiness#3901
Open
rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
[kustomize_deploy] Fix MetalLB CR creation race with webhook readiness#3901rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The MetalLB validating webhook can reject CR creation with "no endpoints available" when the operator's webhook services aren't fully ready yet. The existing deployment availability checks pass before the backing Endpoints objects have addresses populated, creating a window where CR creation fails. Add an explicit wait for all four MetalLB webhook endpoint services (metallb-operator-controller-manager-service, metallb-operator-webhook-server-service, metallb-operator-webhook-service, webhook-service) to have at least one ready address before applying MetalLB CRs. Also add retry logic (retries: 10, delay: 15) to the CR apply step itself as a safety net for any remaining transient webhook failures. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MetalLB validating webhook can reject CR creation with "no endpoints available" when the operator's webhook services aren't fully ready yet. The existing deployment availability checks pass before the backing Endpoints objects have addresses populated, creating a window where CR creation fails.
Add an explicit wait for all four MetalLB webhook endpoint services (metallb-operator-controller-manager-service,
metallb-operator-webhook-server-service,
metallb-operator-webhook-service, webhook-service) to have at least one ready address before applying MetalLB CRs. Also add retry logic (retries: 10, delay: 15) to the CR apply step itself as a safety net for any remaining transient webhook failures.