Skip to content

[shiftstack] Clone shiftstack-qa from GitHub instead of GerritHub#3922

Draft
imatza-rh wants to merge 1 commit intoopenstack-k8s-operators:stablefrom
shiftstack:shiftstack-qa-github-clone
Draft

[shiftstack] Clone shiftstack-qa from GitHub instead of GerritHub#3922
imatza-rh wants to merge 1 commit intoopenstack-k8s-operators:stablefrom
shiftstack:shiftstack-qa-github-clone

Conversation

@imatza-rh
Copy link
Copy Markdown
Contributor

@imatza-rh imatza-rh commented May 10, 2026

Summary

shiftstack-qa moved code review to GitHub PRs (shiftstack/shiftstack-qa#2). The ci-framework shiftstack role default still clones from GerritHub, which is no longer maintained.

  • Change cifmw_shiftstack_qa_repo default to https://github.com/shiftstack/shiftstack-qa
  • Rename cifmw_shiftstack_qa_gerrithub_change to cifmw_shiftstack_qa_change_ref - supports both GitHub PR refs (refs/pull/N/head) and GerritHub change refs (refs/changes/...)

Test plan

  • Verified git clone + git fetch refs/pull/N/head works end-to-end with GitHub URL
  • Confirmed zero external references to old variable name
  • ansible-lint passed
  • Testproject validation with Depends-On pointing to this PR

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign imatza-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@imatza-rh imatza-rh force-pushed the shiftstack-qa-github-clone branch from 924f866 to 86ce265 Compare May 10, 2026 10:30
shiftstack-qa moved code review to GitHub PRs (shiftstack/
shiftstack-qa#2). The role default still clones from
GerritHub, which is no longer maintained.

Assisted-By: Claude Code
Signed-off-by: Itay Matza <imatza@redhat.com>
@imatza-rh imatza-rh force-pushed the shiftstack-qa-github-clone branch from 86ce265 to 22a3c0d Compare May 10, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant