[manage_secrets] Add no_log to debug task printing secret content#4011
Open
stuggi wants to merge 1 commit into
Open
[manage_secrets] Add no_log to debug task printing secret content#4011stuggi wants to merge 1 commit into
stuggi wants to merge 1 commit into
Conversation
The debug task for _secret_content prints sensitive values (pull secrets, CI tokens, kubeconfig) to stdout and ansible.log without no_log. The copy task in the same file correctly uses no_log — the debug task was missed. Uses the same cifmw_nolog pattern as the rest of the role to allow disabling for debugging when needed. Jira: OSPRH-31754 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michburk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug task for _secret_content prints sensitive values (pull secrets, CI tokens, kubeconfig) to stdout and ansible.log without no_log. The copy task in the same file correctly uses no_log — the debug task was missed.
Uses the same cifmw_nolog pattern as the rest of the role to allow disabling for debugging when needed.
Jira: OSPRH-31754