Switch edpm multinode GitHub check jobs to ocp 4 22 by bshewale · Pull Request #4123 · openstack-k8s-operators/ci-framework

bshewale · 2026-08-20T05:08:49Z

No description provided.

openshift-ci · 2026-08-20T05:08:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eshulman2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qodo-code-review · 2026-08-20T05:09:35Z

PR Summary by Qodo

Migrate EDPM multinode checks to OCP 4.22.1

✨ Enhancement ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Adds OCP 4.22.1 cloud nodesets and CRC 2.62.0 nested variants.
• Migrates EDPM multinode check jobs from OCP 4.20.1 to OCP 4.22.1.
• Preserves controller, compute, OCP, RHEL, HCI, and Nova cells topologies.

Diagram

graph TD
  Checks["GitHub checks"] --> Base["Base jobs"] --> Suites["Multinode suites"] --> Nodesets["OCP 4.22 nodesets"] --> Labels["Nodepool labels"]
  Nodesets --> CRC["CRC OCP 4.22"]
  Nodesets --> Hosts["CentOS RHEL hosts"]

High-Level Assessment

The following are alternative approaches to this PR:

1. Generate versioned nodesets

➕ Reduces repetitive topology definitions across OCP releases.
➕ Centralizes CRC versions and nodepool label substitutions.
➕ Lowers the risk of topology variants drifting between releases.
➖ Introduces a generation step and generated-file maintenance.
➖ Makes direct Zuul configuration changes less transparent.
➖ May not align with the repository's established explicit nodeset convention.

Recommendation: Keep the explicit versioned nodesets for this migration because they match the existing Zuul model, retain older OCP definitions for parallel use, and make resource mappings reviewable without tooling. A generator is worth considering only if repeated release migrations continue to add hundreds of near-identical lines.

Files changed (6) +302 / -11

Other (6) +302 / -11

base.yamlMove shared CRC base jobs to OCP 4.22 +4/-4

Move shared CRC base jobs to OCP 4.22

• Updates EDPM multinode and ci-bootstrap base jobs to the OCP 4.22.1 cloud nodeset. Moves the nested CRC base job from CRC 2.56.0 to CRC 2.62.0.

zuul.d/base.yaml

edpm_multinode.yamlUpgrade EDPM and HCI multinode topologies +4/-4

Upgrade EDPM and HCI multinode topologies
• Switches one-, two-, and three-compute EDPM and HCI deployment jobs to matching OCP 4.22.1 nodesets while retaining their existing resource sizes.
zuul.d/edpm_multinode.yaml

kuttl_multinode.yamlRun KUTTL multinode jobs on OCP 4.22 +1/-1

Run KUTTL multinode jobs on OCP 4.22
• Changes the abstract KUTTL multinode base job to use the OCP 4.22.1 CRC cloud nodeset.
zuul.d/kuttl_multinode.yaml

nodeset.yamlDefine OCP 4.22.1 and CRC 2.62.0 nodesets +291/-0

Define OCP 4.22.1 and CRC 2.62.0 nodesets

• Adds 15 versioned nodesets for cloud OCP 4.22.1 and nested CRC 2.62.0 environments. The definitions cover multiple resource sizes, EDPM compute counts, RHEL subscription hosts, TripleO layouts, and Nova cells groupings.

zuul.d/nodeset.yaml

podified_multinode.yamlRun podified multinode jobs on OCP 4.22 +1/-1

Run podified multinode jobs on OCP 4.22
• Updates the abstract podified multinode base job from the OCP 4.20.1 nodeset to its OCP 4.22.1 equivalent.
zuul.d/podified_multinode.yaml

tempest_multinode.yamlRun Tempest multinode jobs on OCP 4.22 +1/-1

Run Tempest multinode jobs on OCP 4.22
• Updates the abstract Tempest multinode base job to provision an OCP 4.22.1 CRC cloud environment.
zuul.d/tempest_multinode.yaml

qodo-code-review · 2026-08-20T05:15:59Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

1. Whitebox check remains 4.20 🐞 Bug ≡ Correctness

Description

The whitebox multinode GitHub check explicitly overrides the migrated two-compute parent with an OCP
4.20 nodeset, so this check does not move to OCP 4.22. The PR already defines the equivalent OCP
4.22 XXL-compute nodeset but never assigns it to the check.

Code

zuul.d/edpm_multinode.yaml[5]
+    nodeset: centos-9-medium-2x-centos-9-crc-cloud-ocp-4-22-1-xxl

Evidence
The changed parent selects OCP 4.22, but the whitebox child explicitly selects OCP 4.20 and is
directly registered in a github-check pipeline. An equivalent OCP 4.22 nodeset with the same two
XXL compute hosts was added by this PR and is available for the override.
zuul.d/edpm_multinode.yaml[3-5]
zuul.d/whitebox_neutron_tempest_jobs.yaml[5-15]
zuul.d/project-templates.yaml[105-116]
zuul.d/nodeset.yaml[711-729]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The whitebox Neutron Tempest multinode GitHub check overrides its migrated parent with an OCP 4.20 nodeset. Update the override to use the newly defined equivalent OCP 4.22 nodeset.

## Issue Context
The appropriate replacement is `centos-9-2x-centos-9-xxl-crc-cloud-ocp-4-22-1-3xl`, which preserves the whitebox job's XXL compute layout.

## Fix Focus Areas
- zuul.d/whitebox_neutron_tempest_jobs.yaml[5-8]
- zuul.d/nodeset.yaml[711-721]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Context sources

Review mode: ⚖️ Balanced: This changes runtime Zuul CI configuration and adds many independently defined nodesets, creating meaningful behavioral and cross-reference risk, but it is primarily a repetitive migration rather than a bug-dense multi-path logic change warranting extended review.

Tip of the day

💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

qodo-code-review · 2026-08-20T05:16:00Z

    name: podified-multinode-edpm-deployment-crc-2comp
    parent: podified-multinode-edpm-deployment-crc
-    nodeset: centos-9-medium-2x-centos-9-crc-cloud-ocp-4-20-1-xxl
+    nodeset: centos-9-medium-2x-centos-9-crc-cloud-ocp-4-22-1-xxl


1. Whitebox check remains 4.20 🐞 Bug ≡ Correctness

The whitebox multinode GitHub check explicitly overrides the migrated two-compute parent with an OCP 4.20 nodeset, so this check does not move to OCP 4.22. The PR already defines the equivalent OCP 4.22 XXL-compute nodeset but never assigns it to the check.

Agent Prompt

## Issue description The whitebox Neutron Tempest multinode GitHub check overrides its migrated parent with an OCP 4.20 nodeset. Update the override to use the newly defined equivalent OCP 4.22 nodeset. ## Issue Context The appropriate replacement is `centos-9-2x-centos-9-xxl-crc-cloud-ocp-4-22-1-3xl`, which preserves the whitebox job's XXL compute layout. ## Fix Focus Areas - zuul.d/whitebox_neutron_tempest_jobs.yaml[5-8] - zuul.d/nodeset.yaml[711-721]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

centosinfra-prod-github-app · 2026-08-20T07:58:51Z