Nova compute conductor novncproxy scheduler by Dyrkon · Pull Request #93 · openstack-k8s-operators/s2i-openstack-containers

Dyrkon · 2026-08-18T11:44:18Z

Don't merge before #74

amoralej · 2026-08-18T14:25:09Z

May you rebase on main?

coderabbitai · 2026-08-19T05:48:52Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9dfec50e-508f-4a57-9269-aacd0944ce14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

amoralej

Overall, comparing to rdo packages and tcib containers, it mostly lgtm. Just a question about dependencies in the compute container.

Also file https://github.com/rdo-packages/nova-distgit/blob/rpm-master/nova-ifc-template is not shipped anywehere, it was in /var/lib/nova/interfaces.template before. I guess it's not longer used?

fmount · 2026-08-19T14:15:08Z

/lgtm - I leave the last approval to @amoralej who already reviewed it and had several comments that have been addressed.

Dyrkon · 2026-08-19T14:16:34Z

Overall, comparing to rdo packages and tcib containers, it mostly lgtm. Just a question about dependencies in the compute container.

Also file https://github.com/rdo-packages/nova-distgit/blob/rpm-master/nova-ifc-template is not shipped anywehere, it was in /var/lib/nova/interfaces.template before. I guess it's not longer used?

Yes, your assumption is correct, it is not used anymore.

rebtoor · 2026-08-19T15:13:42Z

/lgtm

SeanMooney

as a meta coment the schduler and condutor conte is identical and the only delta bethwen that and the novnc proxy is the addtion of novnc,and websockify

i would suggest just instlling those in the nova-api contianer and using that for all podifed nova serivce and having only 2 contiaenrs

nova-api and nova-compute

elfiesmelfie · 2026-08-19T17:55:20Z

You should be able to remove these now. Rebase onto main to get the change.

Dyrkon · 2026-08-20T11:35:14Z

as a meta coment the schduler and condutor conte is identical and the only delta bethwen that and the novnc proxy is the addtion of novnc,and websockify

i would suggest just instlling those in the nova-api contianer and using that for all podifed nova serivce and having only 2 contiaenrs

nova-api and nova-compute

I can do a followup PR for that once we get this in.

SeanMooney · 2026-08-20T11:42:05Z

as a meta coment the schduler and condutor conte is identical and the only delta bethwen that and the novnc proxy is the addtion of novnc,and websockify
i would suggest just instlling those in the nova-api contianer and using that for all podifed nova serivce and having only 2 contiaenrs
nova-api and nova-compute

I can do a followup PR for that once we get this in.

well this cant merge in its current form until the files copied form distgit are remvoed
i would prefer to do this correctly now and consolidate but at a minitme all teh migrat helpre code need to be remvoed

SeanMooney

ok this is much closer.

i think we are missiong the ssh client and if you rebase on main to adress emmas comment i think it would be good to go

we can refien it more in a sperate pr if we proceed with reduign the number of contaienrs

this has been mostly adressed

rebtoor

/lgtm

SeanMooney · 2026-08-24T10:24:19Z

+# Required to build lxml
+libxml2-devel
+libxslt-devel
+# To build bcrypt from source


by the way i dont think nova uses bcrypt anywhere but it may be used by a dependency
[11:25:15]❯ grep bcrypt -R -I nova/ | wc
0 0 0

SeanMooney · 2026-08-24T10:33:52Z

+LABEL summary="OpenStack Nova noVNC Proxy" \
+      io.k8s.description="Nova novncproxy container built from source with kolla interface"
+
+RUN uid_gid_manage tss qemu libvirt nova


nit technically only the nova-compute needs tss qemu libvirt
so while creating the other user has no downside they wont be required in
the scheduler conductor or novncproxy

SeanMooney · 2026-08-24T11:51:01Z

 python-neutronclient==13.0.0
 pyyaml==6.0.3
-redis==8.0.1
+redis==8.1.0


nova does not actully use redis by the way

you could use it for oslo cache but we dont.

we dont need to remvoe this right now but we may want to see if it can be remvoed later

Adds nova-compute, nova-conductor, nova-scheduler, and nova-novncproxy to complete the Nova image set. nova-compute includes libvirt/qemu packages, migration infrastructure, and architecture-conditional display drivers (virtio-vga/virtio-gpu). All images use RPM-provided python3-cryptography (FIPS-compliant), filtered from pip lockfile via build.sh. Signed-off-by: Matěj Mudra <mmudra@redhat.com>

openshift-ci · 2026-08-26T12:57:49Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Dyrkon self-assigned this Aug 18, 2026

amoralej reviewed Aug 18, 2026

View reviewed changes

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch from 108dbda to 3429bc1 Compare August 19, 2026 05:48

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch 3 times, most recently from 9a45b47 to 6e09f68 Compare August 19, 2026 07:56

amoralej reviewed Aug 19, 2026

View reviewed changes

Comment thread containers/nova/nova-compute/bindeps.txt

amoralej reviewed Aug 19, 2026

View reviewed changes

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch 3 times, most recently from a0fb636 to 334b426 Compare August 19, 2026 14:09

openshift-ci Bot assigned rebtoor Aug 19, 2026

openshift-ci Bot added the lgtm label Aug 19, 2026

SeanMooney previously requested changes Aug 19, 2026

View reviewed changes

openshift-ci Bot assigned SeanMooney Aug 19, 2026

openshift-ci Bot removed the lgtm label Aug 19, 2026

SeanMooney reviewed Aug 19, 2026

View reviewed changes

elfiesmelfie reviewed Aug 19, 2026

View reviewed changes

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch 2 times, most recently from 67736d8 to 61fa700 Compare August 20, 2026 07:29

amoralej reviewed Aug 20, 2026

View reviewed changes

Comment thread containers/nova/nova-novncproxy/bindeps.txt Outdated

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch 2 times, most recently from 2c14038 to bf17730 Compare August 21, 2026 09:38

SeanMooney reviewed Aug 21, 2026

View reviewed changes

Comment thread containers/nova/nova-compute/bindeps.txt

SeanMooney reviewed Aug 21, 2026

View reviewed changes

Comment thread containers/nova/nova-compute/Containerfile

SeanMooney reviewed Aug 21, 2026

View reviewed changes

Comment thread containers/nova/nova-compute/config/etc/nova/rootwrap.conf Outdated

Comment thread containers/nova/nova-compute/config/etc/nova/rootwrap.d/compute.filters Outdated

Comment thread containers/nova/nova-novncproxy/pythondeps.txt Outdated

Dyrkon force-pushed the nova-compute-conductor-novncproxy-scheduler branch 4 times, most recently from f14bca2 to 7682961 Compare August 24, 2026 10:03

rebtoor reviewed Aug 24, 2026

View reviewed changes

openshift-ci Bot added the lgtm label Aug 24, 2026

SeanMooney reviewed Aug 24, 2026

View reviewed changes

ashu-011 mentioned this pull request Aug 26, 2026

Add nova compute, conductor, scheduler, and novncproxy containers #134

Closed

ashu-011 force-pushed the nova-compute-conductor-novncproxy-scheduler branch from 7682961 to 2eb99ff Compare August 26, 2026 12:54

openshift-ci Bot removed the lgtm label Aug 26, 2026

SeanMooney approved these changes Aug 26, 2026

View reviewed changes

openshift-ci Bot added the lgtm label Aug 26, 2026

SeanMooney added the approved label Aug 26, 2026

openshift-merge-bot Bot merged commit 63644dc into openstack-k8s-operators:main Aug 26, 2026
4 checks passed

Uh oh!

Conversation

Dyrkon commented Aug 18, 2026

Uh oh!

amoralej commented Aug 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

amoralej left a comment

Choose a reason for hiding this comment

Uh oh!

fmount commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dyrkon commented Aug 19, 2026

Uh oh!

rebtoor commented Aug 19, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SeanMooney left a comment

Choose a reason for hiding this comment

Uh oh!

elfiesmelfie Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dyrkon commented Aug 20, 2026

Uh oh!

SeanMooney commented Aug 20, 2026

Uh oh!

Uh oh!

SeanMooney left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rebtoor left a comment

Choose a reason for hiding this comment

Uh oh!

SeanMooney Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SeanMooney Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

SeanMooney Aug 24, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading

fmount commented Aug 19, 2026 •

edited

Loading