Conversation
Previously a set version only replaced the initial [0, 0] best set data if its score was greater than zero. So if a user scored zero on all versions of a test, or had not started the test, the total returned was also zero. For LTI 1.3 grade passback that resulted in a scoreMaximum of zero being sent, which Canvas rejects with "cannot be zero if line item's maximum is not zero". Now the first version is used if no version has a positive score, and if there are no versions the total is computed from the problems assigned to the user for the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
somiaj
approved these changes
Sep 25, 2026
This is a more informative message, and Moodle is also now sending a JSON response (perhaps it always was, and I was confusing this request with one of the other LTI requests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a set version only replaced the initial [0, 0] best set data if its score was greater than zero. So if a user scored zero on all versions of a test, or had not started the test, the total returned was also zero. For LTI 1.3 grade passback that resulted in a scoreMaximum of zero being sent, which Canvas rejects with "cannot be zero if line item's maximum is not zero".
Now the first version is used if no version has a positive score, and if there are no versions the total is computed from the problems assigned to the user for the test.