system.board improvements#36
Open
dhewg wants to merge 3 commits intoopenwrt:mainfrom
Open
Conversation
Unify the "val + 2" access with a potential invalid access. Signed-off-by: Andre Heider <a.heider@gmail.com>
snprintf(p, "%s", p + x) produces unexpected results, like "4imafdcv" instead of "rv64imafdcv" on my riscv board. Also bump the buffer size while at it, the 'isa' line already has a length of 216 on one of my boards. Signed-off-by: Andre Heider <a.heider@gmail.com>
The used 'isa' line from /proc/cpuinfo contains a '_' seperated long list of features. Break them apart for the human readable string, which also makes the related luci box less insane, as the browser will now use multiple lines for the long list. Signed-off-by: Andre Heider <a.heider@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Just one cleanup patch, one fix and one improvement.
ubus call system board, "system" before:RISC-V (4imafdcv_zicbom_zicbop_zicboz_zicntr_zicond_zicsr_zifencei_zihintpause_zihpm_zaamo_zalrsc_zfh_zca_zcd_zba_zbb_zbc_zbs_zkt_zve32f_zve32x_zve64d_zve64f_zve64x_zvfh_zvkt_sscofpmf_sstc_svinval_svnapot_svpbmtafter:
RISC-V (rv64imafdcv zicbom zicbop zicboz zicntr zicond zicsr zifencei zihintpause zihpm zaamo zalrsc zfh zca zcd zba zbb zbc zbs zkt zve32f zve32x zve64d zve64f zve64x zvfh zvkt sscofpmf sstc svinval svnapot svpbmt)