Skip to content

pkg/manifests: fix dropped walk errors #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alrs wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

pkg/manifests: fix dropped walk errors #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/manifests/bundleloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ func collectWalkErrs(walk filepath.WalkFunc, errs *[]error) filepath.WalkFunc {
}

func (b *bundleLoader) LoadBundleWalkFunc(path string, f os.FileInfo, err error) error {
if err != nil {
return err
}
if f == nil {
return fmt.Errorf("invalid file: %v", f)
}
Expand Down
6 changes: 6 additions & 0 deletions pkg/manifests/packagemanifestloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ func (p *packageManifestLoader) LoadPackage() error {
// LoadPackagesWalkFunc attempts to unmarshal the file at the given path into a PackageManifest resource.
// If unmarshaling is successful, the PackageManifest is added to the loader's store.
func (p *packageManifestLoader) LoadPackagesWalkFunc(path string, f os.FileInfo, err error) error {
if err != nil {
return err
}
if f == nil {
return fmt.Errorf("invalid file: %v", f)
}
Expand Down Expand Up @@ -85,6 +88,9 @@ func (p *packageManifestLoader) LoadPackagesWalkFunc(path string, f os.FileInfo,
}

func (p *packageManifestLoader) LoadBundleWalkFunc(path string, f os.FileInfo, err error) error {
if err != nil {
return err
}
if f == nil {
return fmt.Errorf("invalid file: %v", f)
}
Expand Down
Loading