Repository navigation
ci: cache Minikube downloads and retry a failed Minikube setup - #3659
Conversation
minikube start downloads the Kubernetes binaries (none driver) or the base and preloaded images (docker driver) on every run. With many matrix jobs starting at once, these downloads regularly time out (e.g. a TLS handshake timeout to dl.k8s.io) and fail the job before any test runs. Cache minikube's download cache keyed on the minikube and Kubernetes versions and the driver, and retry the setup once after cleaning up a failed attempt.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title "ci: cache Minikube downloads and retry a failed Minikube setup" matches the main change. The workflow files cache Minikube downloads keyed by runner OS, versions, and driver. They also cont… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title "ci: cache Minikube downloads and retry a failed Minikube setup" matches the main change. The workflow files cache Minikube downloads keyed by runner OS, versions, and driver. They also continue on initial setup failure, clean up the failed cluster, and retry setup. The PR objectives describe the same two goals.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
The cache paths match the setup action’s storage location, retry failures remain blocking, and no unresolved issues were identified.
No open issues 🎉
What changed in this PR
This PR improves CI reliability by caching Minikube downloads and retrying failed cluster setup once before running integration and end-to-end tests.
Changes:
- Cache downloads using keys scoped to the operating system, Minikube version, Kubernetes version, and driver.
- Clean up failed Minikube setup before retrying, while keeping retry failures blocking.
- Centralize version values in job-level environment variables.
| File | Description |
|---|---|
.github/workflows/integration-tests.yml |
Adds download caching and cleanup-before-retry for the none driver. |
.github/workflows/e2e-test.yml |
Adds download caching and cleanup-before-retry for the Docker driver. |
Review effort: Balanced
minikube start downloads the Kubernetes binaries (none driver) or the
base and preloaded images (docker driver) on every run. With many matrix
jobs starting at once, these downloads regularly time out (e.g. a TLS
handshake timeout to dl.k8s.io) and fail the job before any test runs.
Cache minikube's download cache keyed on the minikube and Kubernetes
versions and the driver, and retry the setup once after cleaning up a
failed attempt.
Summary by CodeRabbit