Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR에서는 Fastfile 내에서 Version.xcconfig 파일로부터 MARKETING_VERSION을 직접 읽어와 검증하는 marketing_version_from_xcconfig 메서드를 추가하고 적용하였습니다. 리뷰에서는 정규식 검증 시 0.x.y와 같이 0으로 시작하는 초기 버전을 허용하지 않는 문제를 지적하고, 이를 허용하도록 정규식을 수정할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
#722반영 뒤 전처리 구문이 포함된 원본Info.plist를 Fastlane의get_version_number가 XML로 파싱하면서 발생한CFFormatError해소build_for_store의 마케팅 버전 조회 기준을Application/Shared/Version.xcconfig로 통일#722에서 확정한 Crashlytics 활성화, dSYM 생성·업로드, 생성된 IPA 설정 검증 흐름 유지📝 작업 내용
📌 요약
get_version_number를 통한 원본Info.plist조회 제거Version.xcconfig의MARKETING_VERSION직접 조회와 형식 검증 추가__dir__기준 버전 파일 경로 계산 적용🔍 상세
marketing_version_from_xcconfig추가MARKETING_VERSION키 누락 오류 제공MARKETING_VERSION을 App Store Connect의 최근 빌드 번호 조회에 사용fastlane/Application/Shared/Version.xcconfig를 조회하던 경로 오류를__dir__기준 절대 경로로 수정build_app의CRASHLYTICS_COLLECTION_ENABLED=1, dSYM 생성 설정,verify_store_info_plist호출부 유지fastlane/작업 디렉터리에서MARKETING_VERSION=1.4조회 확인ruby -c fastlane/Fastfile통과bundle check통과bundle exec fastlane lanes통과git diff --check통과0dbc07cf6기준 TestFlight run 29308325910의 빌드와 dSYM 업로드 성공 및 TestFlight 업로드 생략0dbc07cf6기준 App Store run 29312793662의 빌드, dSYM 업로드, App Store Connect 업로드 성공📸 영상 / 이미지 (Optional)