Skip to content

[#42] baseBranch를 포함한 branch 비교 조합을 구성한다#56

Merged
opficdev merged 2 commits into
developfrom
feat/#42
Jul 15, 2026
Merged

[#42] baseBranch를 포함한 branch 비교 조합을 구성한다#56
opficdev merged 2 commits into
developfrom
feat/#42

Conversation

@opficdev

Copy link
Copy Markdown
Owner

🔗 연관된 이슈

🎯 의도

baseBranch와 감시 대상 branch 전체에서 중복과 방향을 제거한 비교 조합 구성

📝 작업 내용

📌 요약

  • branch 이름순 비교 조합 생성
  • branch-pairs.json 디버그 산출물 기록
  • 조합 생성 규칙과 산출물 계약 검증

🔍 상세

  • BranchComparisonPair 타입과 branchPairBuilder 추가
  • baseBranch와 감시 대상 branch 이름의 중복 제거 및 이름순 정렬
  • 자기 자신 조합과 역방향 중복을 제외한 조합 생성
  • 감시 대상 branch 30개와 baseBranch에서 465개 조합 생성 검증
  • mergeRiskWatch의 branch 선별 결과를 이용한 branch-pairs.json 기록
  • 기존 위험 분석, AI 분석, 보고서 생성 흐름의 동작 유지
  • README 디버그 산출물 목록에 branch-pairs.json 계약 추가
  • Node 22 npm run build 통과
  • npm test 108개 통과
  • git diff --check origin/develop...HEAD 통과

📸 영상 / 이미지 (Optional)

해당 없음

@opficdev opficdev self-assigned this Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new branchPairBuilder utility to generate unique, deterministic comparison pairs between a base branch and active branches, which are then saved as a branch-pairs.json debug artifact during the merge risk analysis workflow. The review feedback suggests simplifying the sorting logic in branchPairBuilder.ts by using the default Array.prototype.sort() instead of a custom comparison function, as the default sort is already deterministic and environment-independent.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/branches/branchPairBuilder.ts
@opficdev
opficdev merged commit 668f35a into develop Jul 15, 2026
3 checks passed
@opficdev
opficdev deleted the feat/#42 branch July 15, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

baseBranch를 포함한 branch 비교 조합을 구성한다

1 participant